[Bioc-devel] Version number error

[Martin Morgan]

This seems like a bug in the version check code.

The next number after '999' is '1000', but '9991' is larger than '999', too, so I think both 1000 and 9991 are valid version bumps; '10' is less than '999' so is not a valid version bump.

Note that .99... has no special significance in the third position (your package will be bumped to 1.8.0 in release / 1.9.0 in devel at the next release regardless...) so one would usually only get to '999' if one were a very 'commit'ed person... ;)

Martin

On 9/5/19, 2:02 AM, "Bioc-devel on behalf of Christopher John" <bioc-devel-bounces using r-project.org on behalf of chris.r.john86 using gmail.com> wrote:

    This is just the update in the normal way to github, see the below code.
    
    Please note the change from '1.7.999' to '1.7.10' as requested by Lori
    unfortunately gives the same error message as before. Previously I tried
    version 1.7.9991 which didn't work.
    
    Any ideas? What is the correct version number to change to?
    
    Thanks,
    
    Chris
    
    ### update commands
    
    christopher using RA-MAP:~/M3C$ git checkout master
    M DESCRIPTION
    Already on 'master'
    Your branch is up-to-date with 'origin/master'.
    christopher using RA-MAP:~/M3C$ git add .
    christopher using RA-MAP:~/M3C$ git commit -m "v no change"
    [master 600273a] v no change
     1 file changed, 1 insertion(+), 1 deletion(-)
    christopher using RA-MAP:~/M3C$ git push origin master
    Username for 'https://github.com': crj32
    Password for 'https://crj32@github.com':
    Counting objects: 3, done.
    Delta compression using up to 16 threads.
    Compressing objects: 100% (3/3), done.
    Writing objects: 100% (3/3), 290 bytes | 290.00 KiB/s, done.
    Total 3 (delta 2), reused 0 (delta 0)
    remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
    To https://github.com/crj32/M3C
       942ea47..600273a  master -> master
    christopher using RA-MAP:~/M3C$ git push upstream master
    Counting objects: 8, done.
    Delta compression using up to 16 threads.
    Compressing objects: 100% (8/8), done.
    Writing objects: 100% (8/8), 1.24 KiB | 1.24 MiB/s, done.
    Total 8 (delta 6), reused 0 (delta 0)
    
    ### error
    
    remote: Error: Illegal version bump from '1.7.999' to '1.7.10'. Check
    remote: http://bioconductor.org/developers/how-to/version-numbering/
    remote: for details
    To git.bioconductor.org:packages/M3C.git
     ! [remote rejected] master -> master (pre-receive hook declined)
    error: failed to push some refs to 'git using git.bioconductor.org:
    packages/M3C.git'
    
    On Wed, 4 Sep 2019 at 14:57, Turaga, Nitesh <Nitesh.Turaga using roswellpark.org>
    wrote:
    
    > I suspect this was a Bioconductor hook rejecting the "version" number? Is
    > that correct Chris?
    >
    > Please also reply with the exact error message.
    >
    > Best,
    >
    > Nitesh
    >
    > > On Sep 4, 2019, at 7:58 AM, Shepherd, Lori <Lori.Shepherd using RoswellPark.org>
    > wrote:
    > >
    > > Or perhaps just providing the git commands you tried and the ERROR that
    > was produced with the original  1.7.9991 would be a better place to start
    > so we can evaluate the ERROR.
    > >
    > >
    > > Cheers,
    > >
    > >
    > > Lori Shepherd
    > >
    > > Bioconductor Core Team
    > >
    > > Roswell Park Cancer Institute
    > >
    > > Department of Biostatistics & Bioinformatics
    > >
    > > Elm & Carlton Streets
    > >
    > > Buffalo, New York 14263
    > >
    > > ________________________________
    > > From: Bioc-devel <bioc-devel-bounces using r-project.org> on behalf of
    > Christopher John <chris.r.john86 using gmail.com>
    > > Sent: Wednesday, September 4, 2019 5:48:54 AM
    > > To: bioc-devel using r-project.org <bioc-devel using r-project.org>
    > > Subject: [Bioc-devel] Version number error
    > >
    > > Hi
    > >
    > > I tried to update M3C as follows, and I got an error. What is wrong with
    > > the new version number please? What should it be?
    > >
    > > Version: 1.7.999 --> Version: 1.7.9991
    > >
    > > Thanks,
    > >
    > > Chris
    > >
    > >        [[alternative HTML version deleted]]
    > >
    > > _______________________________________________
    > > Bioc-devel using r-project.org mailing list
    > > https://stat.ethz.ch/mailman/listinfo/bioc-devel
    > >
    > >
    > > This email message may contain legally privileged and/or confidential
    > information.  If you are not the intended recipient(s), or the employee or
    > agent responsible for the delivery of this message to the intended
    > recipient(s), you are hereby notified that any disclosure, copying,
    > distribution, or use of this email message is prohibited.  If you have
    > received this message in error, please notify the sender immediately by
    > e-mail and delete this email message from your computer. Thank you.
    > >       [[alternative HTML version deleted]]
    > >
    > > _______________________________________________
    > > Bioc-devel using r-project.org mailing list
    > > https://stat.ethz.ch/mailman/listinfo/bioc-devel
    >
    >
    >
    > This email message may contain legally privileged and/or confidential
    > information.  If you are not the intended recipient(s), or the employee or
    > agent responsible for the delivery of this message to the intended
    > recipient(s), you are hereby notified that any disclosure, copying,
    > distribution, or use of this email message is prohibited.  If you have
    > received this message in error, please notify the sender immediately by
    > e-mail and delete this email message from your computer. Thank you.
    >
    
    	[[alternative HTML version deleted]]
    
    _______________________________________________
    Bioc-devel using r-project.org mailing list
    https://stat.ethz.ch/mailman/listinfo/bioc-devel