[R-pkg-devel] WARNING: A complete check needs the 'checkbashisms' script.

[brian knaus]

Thank you Dirk "Eddelbuettel" (apologies for my spelling, it's your name,
so I should be able to spell it correctly, particularly if I'm asking you
for help) and Rodrigo Tobar for the responses! It sounds like I've gone
down a rabbit hole that I should not have.

When I omit ```configure``` (in my case it only includes this call to
```checkbashisms```) I build with no ERRORs or WARNINGs on Ubuntu 18.0.4
and R 4.0.2 with ```checkbashisms``` installed. When I build on macos
10.15.6 and R 4.0.2 without ```checkbashisms``` installed I throw the
previously reported WARNING (when using --as-cran but not when I omit this
flag). I feel I need to address this because it is a WARNING. It sounds
like I can assume that CRAN machines will have ```checkbashisms```
installed where necessary and handle this appropriately when not? And that
users will not try to use R CMD check --as-cran? Suspecting like I'm trying
too hard now. But also feeling like I've been down this path with CRAN
already and am trying to respect their time.

Thanks!
Brian

On Mon, Aug 10, 2020 at 8:41 PM Rodrigo Tobar <rtobar using icrar.org> wrote:

> Hi Brian,
>
> The checkbashisms script is invoked by the R checks automatically:
>
>
> https://github.com/wch/r-source/blob/trunk/src/library/tools/R/check.R#L1216-L1267
>
> Thus there shouldn't be any need for you to invoke it manually in your
> configure script, even less so to worry about its presence. You can
> still install it locally so the R checks can proceed without the warning
> (or set _R_CHECK_BASHISMS_ to FALSE to skip that particular check, again
> locally), but that shouldn't be a problem in CRAN, as it should be
> installed there already.
>
> Cheers,
>
> Rodrigo
>
> On 11/8/20 10:54 am, brian knaus wrote:
> > Hi R-pkg-devel,
> >
> > My package
> >
> >
> https://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fknausb%2FvcfR&data=02%7C01%7Crodrigo.tobarcarrizo%40uwa.edu.au%7C6f00588f63164cc6f8d208d83da1e836%7C05894af0cb2846d8871674cdb46e2226%7C1%7C0%7C637327112896039359&sdata=afGjqTjB%2B8lVCmXDWb8OhFNIYwIR%2BoIVX1QLFpLSfwA%3D&reserved=0
> >
> > has been archived on CRAN because I was asked by CRAN to address issues
> > that I was unable to address before the deadline I was given. The issue
> I'm
> > struggling with is that when I use
> >
> > ```
> > R CMD check --as-cran vcfR_1.12.0.tar.gz
> > ```
> >
> > I get
> >
> > ```
> > * checking top-level files ... WARNING
> > A complete check needs the 'checkbashisms' script.
> > See section ‘Configure and cleanup’ in the ‘Writing R Extensions’
> > manual..
> > ```
> > .
> >
> > Dirk Eddelbeuttel has proposed a solution on SO. (Thank you again Dirk!)
> >
> > ```
> >
> https://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstackoverflow.com%2Fa%2F62721142&data=02%7C01%7Crodrigo.tobarcarrizo%40uwa.edu.au%7C6f00588f63164cc6f8d208d83da1e836%7C05894af0cb2846d8871674cdb46e2226%7C1%7C0%7C637327112896039359&sdata=G5BGCuyWMSItqbm0zwWbncrGapgNUldsuOIp6RvQlqs%3D&reserved=0
> > ```
> >
> > I've implemented this change, but I am concerned that it won't be
> accepted
> > by CRAN. My concern is that this works on my local machines (Ubuntu and
> > MacOS), where I can install checkbashisms, but I can't control whether
> > checkbashisms is installed on CRAN machines or on user machines. This
> means
> > it will generate a WARNING on machines where checkbashisms is not
> > installed. Most of me feels that I need to address this somehow. But I do
> > not know how. Part of me is wondering if I should expect users to manage
> > this. Any help would be appreciated!
> >
> > Thank you!
> > Brian (knausb)
> >
> >       [[alternative HTML version deleted]]
> >
> > ______________________________________________
> > R-package-devel using r-project.org mailing list
> >
> https://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstat.ethz.ch%2Fmailman%2Flistinfo%2Fr-package-devel&data=02%7C01%7Crodrigo.tobarcarrizo%40uwa.edu.au%7C6f00588f63164cc6f8d208d83da1e836%7C05894af0cb2846d8871674cdb46e2226%7C1%7C0%7C637327112896039359&sdata=7zy%2BLfU7WVDBzP0sP0axZpg8MF4AsD5wtrTu3plbF3o%3D&reserved=0
> >
>

	[[alternative HTML version deleted]]