[Rd] who frees dd and xd in X11_Open?

[Adrian Trapletti]

Thomas Vogels wrote:

> Peter Dalgaard BSA <p.dalgaard@pubhealth.ku.dk> writes:
>
> > Prof Brian Ripley <ripley@stats.ox.ac.uk> writes:
> >
> > > > Date: Fri, 16 Feb 2001 09:04:45 +0100
> > > > From: Adrian Trapletti <adrian@olsen.ch
> > >
> > > > I don't know if it has something to do with this discussion, but it's
> > > > probably worth reporting it.
> > > >
> > > > Under
> > > > SunOS pul 5.8 Generic sun4u sparc SUNW,Ultra-5_10
> > > > R : Version 1.2.1  (2001-01-15)
> > > > Fvwm95 Version 2.0.43a
> > > > the window manager always crashes when I close an x11() device started
> > > > within R.
> > >
> > > This discussion is about png() and jpeg() devices.  We've had other
> > > reports about FVWM, though.
> >
> > ...and they too refer to improper error handling by X11. I'm somewhat
> > baffled by the effect reported, though. Surely, an application
> > crashing the window manager is a bug in the latter, not the former?
> > What we've heard of before is that closing X11 windows with the window
> > manager crashes R, but this sounds like the other way around.
>
> The question about freeing xd and dd comes indeed from my fiddling
> with the X11 driver and understanding the code there...  As for the
> current handleEvent: there are some events simply ignored (like the
> DestroyNotify event) and some are not reaped due to the sequence of
> events in X11_Close/R_ProcessEvents.  (And the way inclose is handled
> is scary once you think of closing two windows at roughly the same
> time...)  The events that linger after R is done shouldn't confuse the
> window manager, though.
>
> I've put my code, patches, comments, suggestions, etc. at:
> http://www.ece.cmu.edu/~tov/public/R/X11andTk.html
> I'd be curious whether R with the patched handleEvent still crashes
> FVWM95.  Probably but who knows.

First, I was somewhat sleeping when I reported this problem. It is not
window-close which causes the crash, but window-minimize (iconify 1) (sorry for
that).

I recompiled R-1.2.1 with your patch. FVWM95 still crashes when I minimize the
x11 device. Furthermore, no other WM (olwm, fvwm, fvwm2, icewm) crashes.

Adrian


-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-
r-devel mailing list -- Read http://www.ci.tuwien.ac.at/~hornik/R/R-FAQ.html
Send "info", "help", or "[un]subscribe"
(in the "body", not the subject !)  To: r-devel-request@stat.math.ethz.ch
_._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._