[ESS-bugs] ess-mode 5.3.8; after-change-functions; RET at end of file

[Rodney Sparapani]

Martin Maechler wrote:
>>>>>> "MT" == Markus Triska <markus.triska at gmx.at>
>>>>>>     on Mon, 10 Nov 2008 21:58:30 +0100 writes:
>>>>>>             
>
>     MT> Hi Rodney,
>     MT> Rodney Sparapani <rsparapa at mcw.edu> writes:
>
>     >> (if (fboundp 'make-local-hook) (progn
>     >> (make-local-hook 'after-change-functions)
>     >> (add-local-hook 'after-change-functions 'noweb-after-change-function))
>     >> (add-hook 'after-change-functions 'noweb-after-change-function nil t))
>
>     MT> Yes, this is a good way to stay backwards compatible.
>
> Well, this is the bug that I only now detected and which
> "completely" breaks Rnw-mode
> such that I had to retract the freshly released ESS 5.3.9 :
>
> make-local-hook  is defined, but
> add-local-hook  does not exist  ===> error   
>
> and the whole  Rnw-mode is  broken.
>
> If I replace 'add-local-hook' by 'add-hook', things seem to
> work, but of course it's still the wrong if branch.
> The point would have been *NOT* to use make-local-hook
> unless in very outdated versions of emacs.
>
> I am fixing it now (please don't touch it for the moment)...
>
> Do we really still need to support Emacs 20.x ?
> [ The one I have here does no longer work -- it is not finding
>    /usr/lib/X11/locale/locale.alias  and bails out ]
>
> What about Xemacs? How old versions are supported there?
> I currently seem to have access to 21.4.17 on one platform and
> 21.4.21 on another.
>
> Martin
>   
Hi Martin:

If make-local-hook is defined then add-local-hook must be defined as well!
On XEmacs, they both are found in subr.el I don't understand this. What
does GNU Emacs do in this case? Apparently, define one and not the other?!?
No wonder I didn't see that behavior here.

I have no opinion on which old versions need to be supported. That,
of course, can be easily changed by changing the documentation. However,
make-local-hook/add-local-hook appear to be the currently supported
method of handling this functionality on XEmacs (and inherited from
GNU Emacs AFAICT).

FWIW, I don't recommend anything but the current
stable release of XEmacs. However, I don't think you will have any
trouble with relatively recent versions like 21.4.17 and higher
(February 2005 and forward). Sun distributes 21.4.12 (January 2003)
with it's developer tools so it commonly seen in the wild, but it
suffers from the revert-buffer not updating Local Variables bug
<http://ess.r-project.org/Manual/ess.html#fn-1>. Other than that,
it works fine and many people here are using it to my chagrin.

-- 
Rodney Sparapani      Center for Patient Care & Outcomes Research (PCOR)
Sr. Biostatistician              http://www.mcw.edu/pcor
4 wheels good, 2 wheels better!  Medical College of Wisconsin (MCW)
WWLD?:  What Would Lombardi Do?  Milwaukee, WI, USA