[ESS-bugs] ess-mode 5.3.8; after-change-functions; RET at end of file

[Martin Maechler]

>>>>> "MT" == Markus Triska <markus.triska at gmx.at>
>>>>>     on Mon, 10 Nov 2008 21:58:30 +0100 writes:

    MT> Hi Rodney,
    MT> Rodney Sparapani <rsparapa at mcw.edu> writes:

    >> (if (fboundp 'make-local-hook) (progn
    >> (make-local-hook 'after-change-functions)
    >> (add-local-hook 'after-change-functions 'noweb-after-change-function))
    >> (add-hook 'after-change-functions 'noweb-after-change-function nil t))

    MT> Yes, this is a good way to stay backwards compatible.

Well, this is the bug that I only now detected and which
"completely" breaks Rnw-mode
such that I had to retract the freshly released ESS 5.3.9 :

make-local-hook  is defined, but
add-local-hook  does not exist  ===> error   

and the whole  Rnw-mode is  broken.

If I replace 'add-local-hook' by 'add-hook', things seem to
work, but of course it's still the wrong if branch.
The point would have been *NOT* to use make-local-hook
unless in very outdated versions of emacs.

I am fixing it now (please don't touch it for the moment)...

Do we really still need to support Emacs 20.x ?
[ The one I have here does no longer work -- it is not finding
   /usr/lib/X11/locale/locale.alias  and bails out ]

What about Xemacs? How old versions are supported there?
I currently seem to have access to 21.4.17 on one platform and
21.4.21 on another.

Martin

    >> However, I'm not adding kill-all-... without some further guidance.
    >> I've checked this in and it will appear in 5.3.9 RSN.

    MT> Great, thank you. By convention, every major mode starts by calling
    MT> `kill-all-local-variables'. Importantly, this automatically calls
    MT> `change-major-mode-hook'. In lisp/ChangeLog `change-major-mode-hook' is
    MT> confused with `after-change-major-mode-hook'. Using `run-mode-hooks'
    MT> ensures that *after*-change-major-mode-hook is run. This is also
    MT> documented in the "Major Mode Conventions" of the Elisp info manual.

    MT> Thank you and all the best,
    MT> Markus

    MT> _______________________________________________
    MT> ESS-bugs ESS-bugs at stat.math.ethz.ch
    MT> https://stat.ethz.ch/mailman/listinfo/ess-bugs

    MT> _______________________________________________
    MT> ESS-core list: https://stat.ethz.ch/mailman/listinfo/ess-core