[ESS-bugs] run-mode-hooks

[David Reitter]

Dear ESS developers,

`ess-mode' should use `run-mode-hooks' rather than `run-hooks',  
because it is a major mode.  This way, you ensure that `change-major- 
mode-hook' is called (and everything else).

The same may apply to R-mode, etc.

See also below (against 5.3.6, sorry).

Best
- David


--
http://aquamacs.org -- Aquamacs: Emacs on Mac OS X
http://aquamacs.org/donate -- Could we help you? Return the favor and  
support the Aquamacs Project!




*** ess-mode.el	13 Sep 2007 09:45:46 -0400	1.1
--- ess-mode.el	07 Nov 2008 08:31:27 -0500	
***************
*** 417,423 ****
   	'(" [" (ess-local-process-name ess-local-process-name "none") "]"))
     ;; SJE Tue 28 Dec 2004: do not attempt to load object name db.
     ;; (ess-load-object-name-db-file)
!   (run-hooks 'ess-mode-hook)
     (ess-write-to-dribble-buffer "\nFinished setting up ESS-mode.\n"))

   ;;*;; User commands in ess-mode
--- 417,423 ----
   	'(" [" (ess-local-process-name ess-local-process-name "none") "]"))
     ;; SJE Tue 28 Dec 2004: do not attempt to load object name db.
     ;; (ess-load-object-name-db-file)
!   (run-mode-hooks 'ess-mode-hook)
     (ess-write-to-dribble-buffer "\nFinished setting up ESS-mode.\n"))

   ;;*;; User commands in ess-mode