[ESS-bugs] ESS 5.3.7: Bug

[Rodney Sparapani]

Will wrote:
> Hi, Martin! Hi, Rodney!
>
> Yes, the bug seems to be fixed.
>
> I've used a default installation of Emacs (GNU Emacs 22.2.1 
> (i386-mingw-nt5.1.2600) of 2008-03-26 on RELEASE) with ESS version 
> 5.3.7 and only replaced the essa-sas.el (V5.3.7) with essa-sas.el 
> (V5.3.8) exactly like you, Martin, recommended.
>
> The only two comments I have are...
> 1) that (in my humble lisp programming experience) the code of the 
> <ess-sas-submit-region> function could be optimized as the <arg1> and 
> <arg2> variables are not necessary and the function does - as far as I 
> understand it - the same job as the function I suggested earlier.
>
> 2) It seems to be not necessary, but I would recommend also to include 
> the file extension ".sas" in the batch file command to define the SAS 
> syntax file that is processed in SAS batch mode because the extension 
> belongs to the file name (cf. my suggestion).
>
> Anyway, the code works fine for me! Thanks for your help!
>
> Will
Hi Will:

Glad to hear that it works.  In regards to your comments:

1) Actually, arg1 and arg2 are necessary since ess-sas-submit-command 
and ess-sas-submit-command-options are buffer-local variables.  The 
function ess-sas-submit-region changes buffers and if you don't pass 
their values
along as arg1 and arg2, then ESS will look for those variables local to 
the *shell* buffer which wouldn't make a whole lot of sense.  That would 
only work
if you changed the defaults via customize; but then you are really 
talking about
a global variable after all.  So, in general, that is not an effective 
strategy.

2) Just trying to be consistent with the other ess-sas-submit-* commands.
Besides, if the program doesn't end in .[sS][aA][sS], it won't be recognized
by ESS in any case (unless you have changed this in ess-site.el:  but, why
anyone would want to do that I can't imagine).

-- 
Rodney Sparapani      Center for Patient Care & Outcomes Research (PCOR)
Sr. Biostatistician              Department of Medicine
Was 'Name That Tune' rigged?     Medical College of Wisconsin (MCW)
WWLD: What Would Lombardi Do     Milwaukee, WI, USA