[ESS-bugs] ESS 5.3.7: Bug

[Will]

Hi, Martin! Hi, Rodney!

Yes, the bug seems to be fixed.

I've used a default installation of Emacs (GNU Emacs 22.2.1 
(i386-mingw-nt5.1.2600) of 2008-03-26 on RELEASE) with ESS version 5.3.7 
and only replaced the essa-sas.el (V5.3.7) with essa-sas.el (V5.3.8) 
exactly like you, Martin, recommended.

The only two comments I have are...
1) that (in my humble lisp programming experience) the code of the 
<ess-sas-submit-region> function could be optimized as the <arg1> and 
<arg2> variables are not necessary and the function does - as far as I 
understand it - the same job as the function I suggested earlier.

2) It seems to be not necessary, but I would recommend also to include 
the file extension ".sas" in the batch file command to define the SAS 
syntax file that is processed in SAS batch mode because the extension 
belongs to the file name (cf. my suggestion).

Anyway, the code works fine for me! Thanks for your help!

Will

Martin Maechler wrote:
> Hi Will,
> 
> Rodney has in the mean time addressed the bug you've reported.
> 
> Could you try to use the 5.3.8 development version of ESS 
> and check to see if the problem is gone.
> 
> The only file relevant should be
>    https://svn.r-project.org/ESS/trunk/lisp/essa-sas.el
> 
> so you may just try to use that in place of the 5.3.7 one.
> 
> Thanks in advance if you'd confirm the problem is fixed with the
> new code.
> 
> Martin
> 
>>>>>> "W" == Will  <will.eagle at gmx.net>
>>>>>>     on Sun, 18 May 2008 18:41:40 +0200 writes:
> 
>     W> Hi, there!
>     W> Thanks for your quick response! Yes, I suggest to include my corrected 
>     W> function into ESS (without the comments). I'd like to point out that 
>     W> adding <ess-sas-submit-command-options>, ".sas", and the necessary 
>     W> blanks is necessary if you want to configure SAS under Batch Mode (the 
>     W> only mode working under MS Windows) so one can submit code and call the 
>     W> data viewer from within ESS. Otherwise the necessary options for 
>     W> submitting code and viewing data will conflict.
> 
>     W> I found the email again I posted on 2007-10-11 to the ess-bugs list 
>     W> where this issue is described in more detail. If I can get access to the 
>     W> ESS repository I can also change the function myself.
> 
>     W> Best, Will
> 
>     W> Martin Maechler wrote:
>     >>>>>>> "RoSp" == Rodney Sparapani <rsparapa at mcw.edu>
>     >>>>>>> on Fri, 16 May 2008 14:49:25 -0500 writes:
>     >> 
>     RoSp> Will wrote:
>     >> >> 
>     >> >> As I have reported this bug already in the last ESS version 5.3.6, and 
>     >> >> now in 5.3.7, I hope it will be included in version 5.3.8.
>     >> >> 
>     >> >> Best, Will
>     >> >> 
>     >> >> ;; corrected function
>     >> >> 
>     >> >> (defun ess-sas-submit-region ()
>     >> >> "Write region to temporary file, and submit to SAS."
>     >> >> (interactive)
>     >> >> (ess-sas-file-path)
>     >> >> (write-region (region-beginning) (region-end)
>     >> >> (concat (ess-sas-temp-root) ".sas"))
>     >> >> 
>     >> >> (save-excursion
>     >> >> (ess-sas-goto-shell t)
>     >> >> 
>     >> >> (if (and (w32-shell-dos-semantics)
>     >> >> (string-equal ":" (substring ess-sas-file-path 1 2)))
>     >> >> (progn
>     >> >> (insert (substring ess-sas-file-path 0 2))
>     >> >> (comint-send-input)
>     >> >> ))
>     >> >> 
>     >> >> (insert "cd \"" (convert-standard-filename
>     >> >> (file-name-directory ess-sas-file-path)) "\"")
>     >> >> (comint-send-input)
>     >> >> 
>     >> >> (insert (concat ess-sas-submit-pre-command " "
>     >> >> ess-sas-submit-command " "
>     >> >> ess-sas-submit-command-options " " ;; corrected l. 1
>     >> >> (ess-sas-temp-root) ".sas" " " ;; corrected l. 2
>     >> >> ess-sas-submit-post-command)
>     >> >> )
>     >> >> (comint-send-input)
>     >> >> )
>     >> >> )
>     >> >> 
>     RoSp> Is there something weird going on with the repository?  According to my 
>     RoSp> checkout,
>     RoSp> ess-sas-submit-command-options is not used by the function 
>     RoSp> ess-sas-submit-region.
>     >> 
>     >> That's correct. It's not used currently;
>     >> Will, are you proposing to use it? 
>     >> 
>     >> Will, you can always access the current (development) version
>     >> of the ESS code at svn.r-project.org, for the current situation,
>     >> it is 
>     >> https://svn.r-project.org/ESS/trunk/lisp/essa-sas.el
>     >> 
>     >> 
>     RoSp> Can anyone else see this bug?
>     >> 
>     >> I'm not sure, but I think you are the only one (inside ESS-core)
>     >> ever using ESS for SAS.
>     >> Of course, I would use ESS if I ever had to use SAS ..
>     >> 
>     >> Martin
>     >> 
>     >> 
>     RoSp> -- 
>     RoSp> Rodney Sparapani             Medical College of Wisconsin
>     RoSp> Sr. Biostatistician          Center for Patient Care & Outcomes Research
>     RoSp> Was Name That Tune rigged?   Milwaukee, WI, USA
>     >> 
>     RoSp> _______________________________________________
>     RoSp> ESS-bugs ESS-bugs at stat.math.ethz.ch
>     RoSp> https://stat.ethz.ch/mailman/listinfo/ess-bugs
>     >> 
>     RoSp> _______________________________________________
>     RoSp> ESS-core list: https://stat.ethz.ch/mailman/listinfo/ess-core