[ESS-bugs] select-window (C-c M-j) doesn't give input focus to target (*R*) [Carbon GNU Emacs]

[David Reitter]

On 31 Mar 2006, at 17:56, Stephen Eglen wrote:
>
>
>> To reproduce:
>> Arrange two frames: one showing just a buffer in R-mode, the other
>> one showing the *R* process buffer. Enter some R code into the first
>> buffer. Try to evaluate a line from within the first buffer by typing
>> C-c M-j. This reliably produces the bug.
>
> I cannot reproduce this on linux, using latest ESS sources and CVS
> Emacs compiled from today's sources.

I am still getting that bug with a CVS Emacs and ESS 5.2.8.

What system have you tried it on?
Mine is OS X (Carbon port essentially) and from the code in frame.el  
it looks like Windows might behave differently. I can't tell for sure  
- haven't tried.

`eval-*-and-go' seem to evaluate and then call `ess-switch-to-ESS'.  
This function displays the buffer but doesn't select it according to  
the comment:

;; Display the buffer, but don't select it yet.
	(ess-show-buffer
	 (buffer-name (process-buffer (get-process ess-current-process-name)))
	 t)

select-frame and select-window may be called, but this doesn't give  
input focus to the appropriate window. One must use `select-frame-set- 
input-focus' to achieve that.

Note that the bug only occurs when you have two frames, one with a  
single window displaying the R source file, one with a single window  
displaying the *R* process buffer.

>> There has been a change to the behavior of display-buffer (doesn't
>> select target frame any more) a few weeks ago, which should have
>> brought the display-buffer in line with its documentation.
>
> Can you tell me which revision you are referring to here?  A quick
> browse of src/window.c change log showed this to be the newest change
> to display_buffer:
>
> revision 1.525
> date: 2005-11-03 17:11:50 +0000;  author: monnier;  state: Exp;   
> lines: +2 -0
> (Fdisplay_buffer): Fix last change to not use a dedicated window.
>
> Is that what you are referring to?

No, and I'm sorry, it wasn't actually `display-buffer' that saw the  
change, but raise-frame (e-mail by Yamamoto Mitsuharu, 9 Feb 2006, to  
emacs-pretest-bug). This only affects the OS X port, and I'm not sure  
if it really relates to this problem.

>> I'm not sure if this is a problem with ESS or with (Carbon) Emacs -
>> please excuse the cross-posting.
>
> Could you try again with ESS 5.2.12 and a recent CVS Emacs?

Yes, done, same result.

- D