[ESS-bugs] ess-mode 5.2.3; ess-help-mode-hook seems broken

Martin Maechler maechler at stat.math.ethz.ch
Thu Oct 28 09:43:14 CEST 2004


>>>>> "MarkW" == Mark Wilkinson <wilkin at stat.wisc.edu>
>>>>>     on Wed, 27 Oct 2004 19:48:12 -0500 writes:

    MarkW> (add-hook 'ess-help-mode-hook
    MarkW>    '(lambda ()
    MarkW>       ;; Only works for modified ESS installations:
    MarkW>       ;; change (run-hooks ess-help-mode-hook)) to
    MarkW>       ;;        (run-hooks 'ess-help-mode-hook))
    MarkW>       ;; in ess-help.el as late as 5.2.3
    MarkW>       (local-unset-key "q")
    MarkW>       (local-set-key "q" 'ess-kill-buffer-and-go)))
	      

Thank you Mark for the bug report (inside the comment(!) above).
I've already committed the fix.

Just a note on your hook definition:

   The key 'x' already does what you want,
   but you seem to want 'q' to do the same
   and forget about the current functionality of "q".

Of course, that's your choice, 
but I'm still a bit curious way.

Martin Maechler, ETH Zurich




More information about the ESS-bugs mailing list