[ESS-bugs] ess-mode 5.2.3; ess-help-mode-hook seems broken

[Mark Wilkinson]

(add-hook 'ess-help-mode-hook
 		  '(lambda ()
             ;; Only works for modified ESS installations:
             ;; change (run-hooks ess-help-mode-hook)) to
             ;;        (run-hooks 'ess-help-mode-hook))
             ;; in ess-help.el as late as 5.2.3
             (local-unset-key "q")
             (local-set-key "q" 'ess-kill-buffer-and-go)))


Emacs  : GNU Emacs 21.2.1 (i686-pc-linux-gnu, X toolkit)
 of 2003-01-06 on thugbert.cs.wisc.edu
Package: ess-mode 5.2.3

current state:
==============
(setq
 ess-language "S"
 ess-dialect "R"
 ess-ask-for-ess-directory nil
 ess-ask-about-transfile nil
 ess-directory nil
 ess-keep-dump-files "always"
 ess-source-directory "/tmp/"
 )
[ess-site.el]: ess-customize-alist=nil 
[ess-site.el _2_]: ess-customize-alist=nil 
(R): ess-r-versions-create making M-x defuns for R-1.8.1(ess-setq-vars-LOCAL): language=S, dialect=R, buf=nil, comint..echoes=nil, comint..sender=comint-simple-send
(ess-mode-1): ess-language=S, ess-dialect=R buf=testing.R 
(ess-mode-1.5): alist=((ess-local-customize-alist quote R-customize-alist) (ess-language . S) (ess-dialect . R) (ess-suffix . R) (ess-dump-filename-template replace-regexp-in-string S$ ess-suffix ess-dump-filename-template-proto) (ess-mode-editing-alist . S-editing-alist) (ess-mode-syntax-table . R-syntax-table) (ess-help-sec-regex . ess-help-R-sec-regex) (ess-help-sec-keys-alist . R-help-sec-keys-alist) (ess-loop-timeout . ess-S-loop-timeout) (ess-object-name-db-file . ess-r-namedb.el) (ess-retr-lastvalue-command . assign(".Last.value", .ess.lvsave, envir=NULL)
) (ess-save-lastvalue-command . assign(".ess.lvsave",.Last.value,inherits=TRUE)
) (ess-imenu-mode-function quote ess-imenu-R) (inferior-ess-program . inferior-R-program-name) (inferior-ess-objects-command . objects(pos = %d)
) (inferior-ess-search-list-command . search()
) (inferior-ess-help-command . help("%s", htmlhelp=FALSE)
) (inferior-ess-exit-command . q()) (inferior-ess-exit-prompt . Save workspace image? [y/n/c]: ) (inferior-ess-primary-prompt . \([A-Z][][A-Za-z0-9.]*\)*> ) (inferior-ess-secondary-prompt . + ?) (comint-use-prompt-regexp-instead-of-fields . t) (inferior-ess-start-file) (inferior-ess-start-args . ) (ess-STERM . iESS) (ess-editor . R-editor) (ess-pager . R-pager) (inferior-ess-language-start eval inferior-S-language-start)) 
(ess-mode-1.6): editing-alist=((paragraph-start concat \s-*$\| page-delimiter) (paragraph-separate concat \s-*$\| page-delimiter) (paragraph-ignore-fill-prefix . t) (require-final-newline . t) (comment-start . #) (comment-start-skip . #+ *) (comment-column . 40) (indent-line-function quote S-indent-line) (parse-sexp-ignore-comments . t) (ess-set-style . ess-default-style) (ess-local-process-name) (ess-mode-syntax-table . S-syntax-table) (add-log-current-defun-header-regexp . ^\(.+\)\s-+<-[ 	
]*function) (font-lock-defaults quote (ess-mode-font-lock-keywords nil nil ((46 . w))))) 
(ess-setq-vars-LOCAL): language=S, dialect=R, buf=nil, comint..echoes=nil, comint..sender=comint-simple-send

Finished setting up ESS-mode.

(R): ess-dialect=R, buf=testing.R, start-arg=(4)
 current-prefix-arg=(4)

(R): ess-dialect=R, buf=testing.R, start-arg=(4)
 current-prefix-arg=(4)
(inferior-ess 0): ess-start-args=--no-readline --no-save --quiet 
ess-setq-vars-default 0: ess-language=Initial, -dialect=nil, buf=nil, comint..echoes=nil, comint..sender=comint-simple-send
ess-setq-vars-default 1: ess-language=S, -dialect=R, buf=nil, comint..echoes=nil, comint..sender=comint-simple-send
(inf-ess 1): lang=S, dialect=R, tmp-dialect=R, buf=testing.R
(inf-ess 1.1): procname=R temp-dialect=R, buf-name=*R* 
(inferior-ess) Method #3 start=/u/w/i/wilkin/tmp/ buf=*R*
(ess-setq-vars-LOCAL): language=S, dialect=R, buf=nil, comint..echoes=nil, comint..sender=comint-simple-send
(inf-ess 2.1): ess-language=S, ess-dialect=R buf=*R* 
(inf-ess 2.2): start args = --no-readline --no-save --quiet, inf-ess-start-args=--no-readline --no-save --quiet 
(inf-ess finish [S(R), R(nil,nil)]
(ess-multi 0):  inf-ess-start-args=--no-readline --no-save --quiet, comint-..echoes=nil
(i-ess 1): buf=*R*, lang=S, comint..echo=nil, comint..sender=comint-simple-send,
(i-ess 2): buf=*R*, lang=S, comint..echo=t, comint..sender=inferior-R-input-sender,
(ess-setq-vars-LOCAL): language=S, dialect=R, buf=nil, comint..echoes=t, comint..sender=inferior-R-input-sender
(i-ess 3): curr-buf=*R*, comint..echo=t, comint..sender=inferior-R-input-sender,
(ess-multi post inf-ess: start-args=--no-readline --no-save --quiet, comint-echoes=t
(ess-multi 1):  start-args=--no-readline --no-save --quiet 
Making Process...Buf *R*, Proc R, Prog R
 Start File=nil, Args= --no-readline --no-save --quiet.
(R): inferior-ess-language-start=options(STERM='iESS', editor='emacsclient')

(R): ess-dialect=R, buf=testing.R, start-arg=(4)
 current-prefix-arg=(4)
(inferior-ess 0): ess-start-args=--no-readline --no-save --quiet 
ess-setq-vars-default 0: ess-language=S, -dialect=R, buf=nil, comint..echoes=nil, comint..sender=comint-simple-send
ess-setq-vars-default 1: ess-language=S, -dialect=R, buf=nil, comint..echoes=nil, comint..sender=comint-simple-send
(inf-ess 1): lang=S, dialect=R, tmp-dialect=R, buf=testing.R
(inf-ess 1.1): procname=R temp-dialect=R, buf-name=*R* 
(inferior-ess) Method #3 start=/u/w/i/wilkin/tmp/ buf=*R*
(ess-setq-vars-LOCAL): language=S, dialect=R, buf=nil, comint..echoes=nil, comint..sender=comint-simple-send
(inf-ess 2.1): ess-language=S, ess-dialect=R buf=*R* 
(inf-ess 2.2): start args = --no-readline --no-save --quiet, inf-ess-start-args=--no-readline --no-save --quiet 
(inf-ess finish [S(R), R(R,nil)]
(ess-multi 0):  inf-ess-start-args=--no-readline --no-save --quiet, comint-..echoes=nil
(i-ess 1): buf=*R*, lang=S, comint..echo=nil, comint..sender=comint-simple-send,
(i-ess 2): buf=*R*, lang=S, comint..echo=t, comint..sender=inferior-R-input-sender,
(ess-setq-vars-LOCAL): language=S, dialect=R, buf=nil, comint..echoes=t, comint..sender=inferior-R-input-sender
(i-ess 3): curr-buf=*R*, comint..echo=t, comint..sender=inferior-R-input-sender,
(ess-multi post inf-ess: start-args=--no-readline --no-save --quiet, comint-echoes=t
(ess-multi 1):  start-args=--no-readline --no-save --quiet 
Making Process...Buf *R*, Proc R, Prog R
 Start File=nil, Args= --no-readline --no-save --quiet.
(R): inferior-ess-language-start=options(STERM='iESS', editor='emacsclient')
(ess-setq-vars-LOCAL): language=S, dialect=R, buf=nil, comint..echoes=nil, comint..sender=comint-simple-send