[BioC] bug in combine

[Kasper Daniel Hansen]

On Jan 25, 2010, at 19:42 PM, Seth Falcon wrote:

> Hi Kasper,
> 
> On 1/21/10 7:06 PM, Kasper Daniel Hansen wrote:
>> The combine method with signature (x = data.frame, y = data.frame)
>> assumes that the class of a given column is a one-length vector (in
>> various if and switch statements).  However, class(x) can return a
>> vector of length>  1 for S3 objects.
>> 
>> This is the case for the DataTime column in the phenoData for an
>> object created by oligo::read.celfiles.  This column contains the
>> scan date of the arrays and is of class [1] "POSIXt"  "POSIXct"
> 
> I've committed a fix for this to Biobase in devel.  When you get a chance, can you test it out and let us know if it now works as you are expecting?

It works, using Biobase 2.7.4

> We could then see about porting the fix to the release.

While this was a clear bug, it throws an error when something is wrong, so I see little reason to backport it, unless someone else has the same problem.

Thanks,
Kasper


> Thanks,
> 
> + seth
> 
> -- 
> Seth Falcon
> Bioconductor Core Team | FHCRC