[Bioc-devel] [Bioconductor/Contributions] New package: preciseTAD (#1553)

[Spiro Stilianoudakis]

  Hi Nitesh,

Thank you for your message. I am a little confused because I thought I
addressed the requested changes that were proposed in a previous email. I
have listed the things that I addressed in red:

* NOTE: Avoid 1:...; use seq_len() or seq_along()

* Use <- instead of = within the code. It's more "R" like. Be consistent.

* Remove the "nested" functions and put them outside the main

The only point I have not changed yet was the following:

* Try to break up the function like createTADdata into multiple
functions with some helper functions.

I would prefer to keep the function as is for ease of use. But I
understand if it needs to be broken up and I will try to make the
changes if necessary.

Could you please let me know if there are additional changes that you
had in mind? Thank you for taking the time to review my package!


Best,


Spiro Stilianoudakis

PhD Candidate | Department of Biostatistics

Virginia Commonwealth University



On Wed, Sep 16, 2020 at 12:42 PM Nitesh Turaga <notifications using github.com>
wrote:

> Hi @stilianoudakis <https://github.com/stilianoudakis>
>
> It doesn't seem like you made some of the requested changes in the review
> for the package. If you want your package to accepted in the next release
> cycle please try to make the fixes in the next week.
>
> http://bioconductor.org/developers/release-schedule/
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/Bioconductor/Contributions/issues/1553#issuecomment-693526295>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AHSVMWO6PWIA64E6H2ULS33SGDTFRANCNFSM4OZTJATQ>
> .
>

	[[alternative HTML version deleted]]