[Bioc-devel] Reverting on the 'master' branch

[Turaga, Nitesh]

Hi Roel,

I think at this point it makes sense to move forward. It is more trouble than it's worth to do "hard resets" and then edit version numbers manually. 

Or another thing you could do is, roll out some big changes before the next release ;) 

Best,

Nitesh 

> On Mar 2, 2020, at 5:09 PM, Roel Janssen <roel using gnu.org> wrote:
> 
> Dear Nitesh,
> 
> Thanks for the quick replies.  And sorry for mixing your first and last name up.
> :)
> 
> Well, we'd like to reserve 2.0.0 of our package for a "big feature update".  But
> after some local testing we found a few bugs we cannot easily resolve.  I
> already pushed those changes to the Bioconductor repository to check out whether
> it would go smoothly through the continuous integration system of Bioconductor.
> 
> I think reverting makes sense, but if that's not an option I'll reconsider our
> options.
> 
> Kind regards,
> Roel Janssen
> 
> 
> On Mon, 2020-03-02 at 19:13 +0000, Turaga, Nitesh wrote:
>> I suggest you go forward with the version numbering. 
>> 
>> 1.99.0 --> 1.99.1 
>> 
>> At the next release your package will have 2.0.0. Take a look at the version
>> numbering document  
>> http://bioconductor.org/developers/how-to/version-numbering/.
>> 
>> Make the changes you need to and go to version number 1.99.1. This is the most
>> straightforward way to deal with the problem at hand.
>> 
>> Best,
>> 
>> Nitesh 
>> 
>>> On Mar 2, 2020, at 2:08 PM, Roel Janssen <roel using gnu.org> wrote:
>>> 
>>> Dear Turaga,
>>> 
>>> How do you suggest I do the equivalent of reverting a commit?
>>> My package name is MutationalPatterns.
>>> 
>>> Kind regards,
>>> Roel Janssen
>>> 
>>> 
>>> On Mon, 2020-03-02 at 17:40 +0000, Turaga, Nitesh wrote:
>>>> Hi Roel,
>>>> 
>>>> You cannot revert on the Git Bioconductor repo.
>>>> 
>>>> What is your package name? 
>>>> 
>>>>> On Mar 2, 2020, at 10:51 AM, Roel Janssen <roel using gnu.org> wrote:
>>>>> 
>>>>> Dear Bioconductor developers,
>>>>> 
>>>>> I'd like to revert the changes I made on the development branch
>>>>> ("master" in Git), but a pre-receive hook that checks version numbers
>>>>> prevents me from reverting the change:
>>>>> 
>>>>> remote: Error: Illegal version bump from '1.99.0' to '1.13.0'
>>>>> 
>>>>> The commit I am trying to revert bumps the version number from '1.13.0'
>>>>> to '1.99.0'.  What should I do now?
>>>>> 
>>>>> Kind regards,
>>>>> Roel Janssen
>> 
>> 
>> This email message may contain legally privileged and/or confidential
>> information.  If you are not the intended recipient(s), or the employee or
>> agent responsible for the delivery of this message to the intended
>> recipient(s), you are hereby notified that any disclosure, copying,
>> distribution, or use of this email message is prohibited.  If you have
>> received this message in error, please notify the sender immediately by e-mail 
>> and delete this email message from your computer. Thank you.
>> 
> 
> 



This email message may contain legally privileged and/or confidential information.  If you are not the intended recipient(s), or the employee or agent responsible for the delivery of this message to the intended recipient(s), you are hereby notified that any disclosure, copying, distribution, or use of this email message is prohibited.  If you have received this message in error, please notify the sender immediately by e-mail and delete this email message from your computer. Thank you.