[Bioc-devel] About rcellminerData and rcellminerData new versions

Tue Aug 25 16:30:51 CEST 2020

Hi Nitesh,

I made the changes locally:

nci-02048674-ML:rcellminerData elloumif$ git status

On branch RELEASE_3_11

Your branch and 'upstream/RELEASE_3_11' have diverged,

and have 1 and 21 different commits each, respectively.

  (use "git pull" to merge the remote branch into yours)

Should I do now:

git push -f upstream RELEASE_3_11 (with option -f) ?

Fathi

From: "Turaga, Nitesh" <Nitesh.Turaga using RoswellPark.org>
Date: Tuesday, August 25, 2020 at 9:36 AM
To: "Elloumi, Fathi (NIH/NCI) [C]" <fathi.elloumi using nih.gov>
Cc: Martin Morgan <mtmorgan.bioc using gmail.com>, Hervé Pagès <hpages using fredhutch.org>, bioc-devel <bioc-devel using r-project.org>, Nitesh Turaga <nitesh.turaga using gmail.com>
Subject: Re: [Bioc-devel] About rcellminerData and rcellminerData new versions

Hi Fathi,

You can try those steps. Let me know if it works.

Nitesh

On Aug 25, 2020, at 9:28 AM, Elloumi, Fathi (NIH/NCI) [C] <fathi.elloumi using nih.gov<mailto:fathi.elloumi using nih.gov>> wrote:

Dear Martin,

I have attached my commit log for my local branch RELEASE_3_11 for package rcellminerData. To undo the changes and return the last April content, here what I plan to do locally:

- git reset -- hard  414dbc7bc3ab5c507dfca01e91005d7ebc62f282  (last commit from Hervé)
- change version in DESCRIPTION to 2.10.3 and commit this change locally
- git push upstream RELEASE_3_11

Please let me know if these steps are correct.

Thanks for your help.

Fathi

On 8/25/20, 7:06 AM, "Martin Morgan" <mtmorgan.bioc using gmail.com<mailto:mtmorgan.bioc using gmail.com>> wrote:

   The more straight-forward approach is to simply add a commit to the RELEASE_3_11 branch that undoes the changes you do not wish to publish, except with a version bump (to version 2.10.3?)

   Martin

   On 8/24/20, 8:02 PM, "Bioc-devel on behalf of Elloumi, Fathi (NIH/NCI) [C] via Bioc-devel" <bioc-devel-bounces using r-project.org<mailto:bioc-devel-bounces using r-project.org> on behalf of bioc-devel using r-project.org<mailto:bioc-devel using r-project.org>> wrote:

       Dear Hervé,

       Thank you very much for your clarification. I already pushed updates (more data)  that will have impact on the output. I saw that you committed the April 27th version (2.10.0) for RELEASE_3_11. Looking at this link : https://secure-web.cisco.com/1GbaxXXZLBLRIoJalQWlchTBBJ_rLRkSsnlF6Ekz583a10uUnZLP-YgG4SnC6tgST76n4JiQeUssWmH3bjPbQbmTGY3usbOToAgyca06FFa_GSMlAKyLhBNsAE8c68p17FA_qtJoXwj-Pg7HrKh4M_WMMVqxgmj8pQnPQH9q1OEg34sOVuqkhtKeSKg_kBXoC4l0QcMnE0D1UtBGagtSMDWyn2Jjfaahpd14A9DhQMy7sOKqRxnSdVG0FhUBR8X7OolJ45XePxmXEKVXPTR2CU8D17j6GQq9JnkHgJ9v_0TFmnw_6vfazZq_sM__fTu1UOax3GMQOpOkLS6l-cSSyYS4oZDrvZj02X8cW5bejVVo/https%3A%2F%2Fbioconductor.org%2Fdevelopers%2Fhow-to%2Fgit%2Fabandon-changes%2F , it seems that the Bioconductor team can reset a previous commit. Please let me know if this the right way to do it as described in the previous link. Please advise.

       Best,

       Fathi

       On 8/21/20, 5:45 PM, "Hervé Pagès" <hpages using fredhutch.org<mailto:hpages using fredhutch.org>> wrote:

           Hi Fathi,

           The purpose of the "only bug fixes and documentation improvements in
           release" policy is **stability** of the current release (BioC 3.11).
           That is, we want to avoid disruption and to make analyses that use BioC
           3.11 as reproducible as possible. This means that if the changes to the
           RELEASE_3_11 branch of the rcellminer and rcellminerData packages have
           the potential to break some of the scripts that your users are using for
           their analyses, or to change their output, then these changes should not
           be pushed to the RELEASE_3_11 branch.

           Note that we can only realistically aim at preserving things as stable
           as possible within the current release. Of course your software should
           be able to evolve over time. This is why important changes are allowed
           in devel (BioC 3.12).

           So the important question is: are the changes you pushed to BioC 3.11
           going to preserve stability? You are in the best position to answer that
           question. We (Nitesh and myself) lack context to answer it. Maybe Daniel
           knows a little bit more about what kind of changes you made but
           unfortunately he's no longer part of the BioC core team.

           Bottom line is: If the changes don't preserve stability, please don't
           push them to the release branch.

           Please don't hesitate to ask on the bioc-devel mailing list if you have
           concerns or questions about this.

           Best,
           H.

           On 8/21/20 09:34, Elloumi, Fathi (NIH/NCI) [C] wrote:

Dear Bioconductor team,

As mentioned in my previous email (please see below), do you consider
adding and cleaning data an enhancement should be only included in the
develop branch and NOT in the current release (3_11) branch version but
in the new release 3_12?

I followed the instructions at
https://secure-web.cisco.com/1RUDS3iVBzcPhtbIZ04DnB8BcLmnwA9aO8_CkzKa8vxFPZkiGBrOiKmqdDA9N0alyItJdG3VJV_KvF9W_mUDiKzlO-taTgNHE0BIcItKedy2Rj_husqSBFOPbe0NGfgUgYXO9ZornEOJeqBWsQJVv0gW_OyFJRCMfzma1X3e3UO-frccNwYybj44Si-NNW4PPei1amKD89FP06sG7gVX1f7RcBKSrFM3_wLZJtwEebJDN_NBm6ZSzkeaugO3Zmx8sfNv-EM0Rm_q5Zms9-S8eO6u70UUgWh3J8FtkbCctnAre4KN2R9lbWkuzAzGuICxIXzdl_RVJ3s0Z6QFRYp8gdyWoYuFpC8HSE_cQYwSoc9g/https%3A%2F%2Fbioconductor.org%2Fdevelopers%2Fhow-to%2Fgit%2Fsync-existing-repositories%2F
<https://secure-web.cisco.com/1MirrTDPJF8rFZddf6mioZ7rkn6ls2GBZM425RxETNjK-gkQ9l64oPgJxNRdfr0nbzs_qC9B275F9_sJ44vN8KsjSDsEIPnBIsu8HRqJaoEFz4eMqLdvOhPY4QX5glk2J5jUxartd3ZnEmQQ0E_lMPyHaKx-Vmrod35HRnZbbPCSdX6rhGLTuIEQXCopU5clJmTyg2xN_kTB9TqmRnIOM_qren9_tiruyvOEVzZymc06RF8p9ndR72tMS7iZl6P1VGhfm7ZLyB-EqXqaH6GdqZw1A5aCUEewhSRygmoEuYEzuI1mdZxqiDXieumuYbsxI/https%3A%2F%2Furldefense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps-3A__bioconductor.org_developers_how-2Dto_git_sync-2Dexisting-2Drepositories_%26d%3DDwMGaQ%26c%3DeRAMFD45gAfqt84VtBcfhQ%26r%3DBK7q3XeAvimeWdGbWY_wJYbW0WYiZvSXAJJKaaPhzWA%26m%3DARmhemKVIMghSoos_q1dvQqxgobSqzyAD0FygSN-ZKU%26s%3DTgJZrpJBaFZWeoPF8RdX5IiuL0buMRdvjYdIcWDdyNo%26e%3D>
with instruction to update on both devel and release branches.

Please advise.

Best,

Fathi

*From: *"Elloumi, Fathi (NIH/NCI) [C]" <fathi.elloumi using nih.gov<mailto:fathi.elloumi using nih.gov>>
*Date: *Friday, August 21, 2020 at 10:51 AM
*To: *"Van Twisk, Daniel" <Daniel.VanTwisk using RoswellPark.org<mailto:Daniel.VanTwisk using RoswellPark.org>>
*Subject: *About rcellminerData and rcellminerData new versions

Dear Daniel,

This week I pushed new version (2.10.2) for both packages rcellminer and
rcellminerData in the release_3_11 adding new drug data and cleaning
some “bad” experiments. Do you consider this against your policy here below.

/From the Bioconductor paper in 2004/

/(//https://secure-web.cisco.com/1cA6keaMHbxEtUr5Av7UyN63ruCv5VudpZsHgVIALgcjiKL3E1PEK98IMbGS2jIcxrMyYJ6g98XQtgKdAdza6_nnV4rTCCWm9dEQOUrV5_VMdM1fx0pC_jrN6jOljyCFwJ_DZlaR-AeJ_ffHAB4gHSFnrYIDdUvHUExEMQLnzFQslw_jgo8fm1BFSkNCMNTwcLmhZG5LxrCnAu5EfwS6MWvaV_vUTAMvIv1xM4CFM8lVe_Wh9Djdb3lPSYVi9_jF1f80foQf3EYoOyyQcyO9wizaG3-3efNQqv2EC4SVVzyBGiJy5bCE6mfxRwxADrY4WR8EwdYHE-Q3I1WzV41rrwg/https%3A%2F%2Fgenomebiology.biomedcentral.com%2Farticles%2F10.1186%2Fgb-2004-5-10-r80%2F
<https://secure-web.cisco.com/11_Rwe6GUKBLOYngXgyOtk7AI0Af_QWtDXswR-V5pmFLTLKAayrpTm5W-KmXZA02UhLTXFxe4nuWWz-ZF0hHrmk04PnS-QvmrcGDF9yDcHi8XUhUjMwhiQiQ0bIYv_h8yeapZgnK06HYz-_RMkO5aaXtF7PGRzswdl2KsZY6XVuvvTsKIxspDqYgjoMRsgbTTKnQItOwMLMnka7_SvjhKKpN9ZqTon9aniJ2AKmtnQuhlZh1ZL_b3AQPJ57XN4oOiIeU2P2by3-kYQ70hO7O82PZC6qqu04dGyQ630PHCAmF8Ka6PEKHruLA4Rb6BfrqL/https%3A%2F%2Furldefense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps-3A__genomebiology.biomedcentral.com_articles_10.1186_gb-2D2004-2D5-2D10-2Dr80%26d%3DDwMGaQ%26c%3DeRAMFD45gAfqt84VtBcfhQ%26r%3DBK7q3XeAvimeWdGbWY_wJYbW0WYiZvSXAJJKaaPhzWA%26m%3DARmhemKVIMghSoos_q1dvQqxgobSqzyAD0FygSN-ZKU%26s%3DYLZtYlTV7z-tuoZq2DBOY6jMZviyPBSyBTh1plvFEzI%26e%3D>/):/

/The only changes allowed to be made on the release version are bug/

/fixes and documentation improvements. This ensures that users will not/

/encounter radical new behaviors in code obtained in the release/

/version. All other changes such as enhancements or design changes are/

/carried out on the development branch [34]./

Please let me know asap and if needed we will back to previous commit.

Thanks,

-- Fathi

Fathi Elloumi, PhD

Sr. Bioinformatics Software Engineer

Contractor GDIT Inc

Developmental Therapeutics Branch

NIH/NCI/CCR

Phone: 240-760-6601

           --
           Hervé Pagès

           Program in Computational Biology
           Division of Public Health Sciences
           Fred Hutchinson Cancer Research Center
           1100 Fairview Ave. N, M1-B514
           P.O. Box 19024
           Seattle, WA 98109-1024

           E-mail: hpages using fredhutch.org<mailto:hpages using fredhutch.org>
           Phone:  (206) 667-5791
           Fax:    (206) 667-1319

       _______________________________________________
       Bioc-devel using r-project.org<mailto:Bioc-devel using r-project.org> mailing list
       https://secure-web.cisco.com/1fF8DO8xt98KJqLSm_IqTdATPX42kaWjouRpAnuVeo0sW5JnNki4WREGsotOce3V_tai3c0UBrzQCmyNCGSGAZXs1oXyApyYaqJnAxUVFqezArkWwR3jcVrdIQf1WGLt-BTJHqNo2Ehve3NKBTG2S6xw6mpgqdZIZw29DiWV5dxl0OLhcPgqA_Fa03uTt3Em5TfzAMcnkaSZI8tQjlWVmFEw0xndxYqQEQl5hI0JcVWFgFj_fqHuKDKY8nLK_gh1gPKNU1dDuJgkWbR2KXsn1rHmvkrh8CZcsfVAWl_WER5Ibd3vP7bF5d_GKfXneH8SQ0CWrrxB6LDfMWcT5v11p0Q/https%3A%2F%2Fstat.ethz.ch%2Fmailman%2Flistinfo%2Fbioc-devel

<Screen Shot 2020-08-25 at 9.12.19 AM.png>

This email message may contain legally privileged and/or confidential information. If you are not the intended recipient(s), or the employee or agent responsible for the delivery of this message to the intended recipient(s), you are hereby notified that any disclosure, copying, distribution, or use of this email message is prohibited. If you have received this message in error, please notify the sender immediately by e-mail and delete this email message from your computer. Thank you.

	[[alternative HTML version deleted]]