[Bioc-devel] annotation() to BiocGenerics?

[Vincent Carey]

On Fri, Sep 21, 2012 at 12:26 PM, Robert Castelo <robert.castelo at upf.edu> wrote:
> hi Martin,
>
>
> On 09/21/2012 05:59 PM, Martin Morgan wrote:
>>
>> On 09/21/2012 05:05 AM, Benilton Carvalho wrote:
>>>
>>> Replace
>>>
>>> Biobase::`annotation<-`(eScoEset, "")
>>>
>>> by
>>>
>>> Biobase::`annotation<-`(eScoEset, value="")
>>
>>
>> why not just
>>
>> annotation(eScoEset) <- ""
>>
>> with importFrom(Biobase, "annotation<-") in the NAMESPACE?
>
>
> well, my understanding of the general policy to use classes and methods
> defined in other packages is that i should *always* "import" them in the
> NAMESPACE file.
>
> however, somehow i feel more comfortable using this pkg::f() idiom when i
> call something defined somewhere else because just reading the code i know
> immediately where imported things come from.
>
> is there any reason related to performance, correctness or coding style by
> which you think i should not do it?

> unix.time( for (i in 1:100000 ) base::sin )
   user  system elapsed
  1.109   0.004   1.120
> unix.time( for (i in 1:100000 ) sin )
   user  system elapsed
  0.010   0.000   0.011

ymmv

>
> thanks,
> robert.
>
>
> _______________________________________________
> Bioc-devel at r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/bioc-devel