[Bioc-devel] svn commit fails

[Hervé Pagès]

Hi Jelle,

We've added a pre-commit hook to our svn repo a few weeks ago which
purpose was to prevent developers from committing files that differ
only in case. See the announcement here:

   https://stat.ethz.ch/pipermail/bioc-devel/2009-January/001770.html

It seems that this new setup is also enforcing comments for commits.
That was not intended. In fact I was not aware of this new behaviour
until I saw your post.

Just FYI the pre-commit script we are using is check-case-insensitive.pl
from:

   http://svn.collab.net/repos/svn/branches/1.4.x/contrib/hook-scripts/

When we installed this script on our svn server, we also inadvertendly
activated some code that make sure that the log message contains some
text. Since this is indeed considered good practice, let's keep it for
now (unless there is some strong disagreement about it).

I added an informative error message so now you will get:

   Transmitting file data .svn: Commit failed (details follow):
   svn: MERGE request failed on '/bioconductor/trunk/madman/Rpacks/Biostrings'
   svn: 'pre-commit' hook failed with error output:

     Please comment your commit. Thanks!

       The Biocore Team

Cheers,

H.


J.J.Goeman at lumc.nl wrote:
>  Dear developers,
> 
> Holger Schwender suggested to add a comment to the svn. This seems to be
> the solution.
> 
> Are comments obligatory for commits?
> 
> Kind regards,
> 
> Jelle
> 
> 
>> -----Original Message-----
>> From: bioc-devel-bounces at stat.math.ethz.ch 
>> [mailto:bioc-devel-bounces at stat.math.ethz.ch] On Behalf Of 
>> J.J.Goeman at lumc.nl
>> Sent: 26 January 2009 12:20
>> To: bioc-devel at stat.math.ethz.ch
>> Subject: [Bioc-devel] svn commit fails
>>
>>
>>  Dear all,
>>
>> When I try to commit my package to
>> https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/gl
>> obaltest,
>> it fails with the following not-so-informative error message. 
>> I have no
>> clue where to look for a source of this problem. Does anybody have a
>> suggestion?
>>
>>
>> Modified: M:\R\packages\globaltest\DESCRIPTION  
>> Modified: M:\R\packages\globaltest\R\globaltest.R  
>> Modified: M:\R\packages\globaltest\R\internal.R  
>> Modified: M:\R\packages\globaltest\changelog.txt  
>> Sending content: M:\R\packages\globaltest\R\globaltest.R  
>> Sending content: M:\R\packages\globaltest\DESCRIPTION  
>> Sending content: M:\R\packages\globaltest\changelog.txt  
>> Sending content: M:\R\packages\globaltest\R\internal.R  
>> Error: Commit failed (details follow):  
>> Error: 'pre-commit' hook failed with error output:  
>> Finished!:   
>>
>> svn update seems to work without problems.
>>
>> I'm using win XP with
>>
>> TortoiseSVN 1.5.6, Build 14908 - 32 Bit , 2008/12/20 11:51:04
>> Subversion 1.5.5, 
>> apr 1.2.12
>> apr-utils 1.2.12
>> berkeley db 4.4.20
>> neon 0.28.3
>> OpenSSL 0.9.8i 15 Sep 2008
>> zlib 1.2.3
>>
>> Best regards,
>>
>> Jelle
>>
>> www.msbi.nl/goeman 
>>
>> _______________________________________________
>> Bioc-devel at stat.math.ethz.ch mailing list
>> https://stat.ethz.ch/mailman/listinfo/bioc-devel
>>
> 
> _______________________________________________
> Bioc-devel at stat.math.ethz.ch mailing list
> https://stat.ethz.ch/mailman/listinfo/bioc-devel

-- 
Hervé Pagès

Program in Computational Biology
Division of Public Health Sciences
Fred Hutchinson Cancer Research Center
1100 Fairview Ave. N, M2-B876
P.O. Box 19024
Seattle, WA 98109-1024

E-mail: hpages at fhcrc.org
Phone:  (206) 667-5791
Fax:    (206) 667-1319