[Bioc-devel] bug-report for combine

[Laurent Gautier]

2007/7/18, Seth Falcon <sfalcon at fhcrc.org>:
> Hi Laurent,
>
> "Laurent Gautier" <lgautier at gmail.com> writes:
> > It seems to be a problem with 'identical'.
> >
> > The following patched "combine" seems to fix the problem
> > (workaround for zero-rows data.frames:
> > length(sharedRows) == 0))
> > )
>
> Thanks for the report and the fix.  Would you be willing to resend as
> a real patch?  By that I mean:
>    - make the change in an up to date svn working copy of Biobase
>    - send output of 'svn diff'

I would be willing
(...'just have to find the time to do it ;-) )

(and I also fixed a probable other bug since my last post)


> We should also add your test case to the unit tests in inst/UnitTests

I was about to suggest it.


> + seth
>
> --
> Seth Falcon | Computational Biology | Fred Hutchinson Cancer Research Center
> http://bioconductor.org
>