[Bioc-devel] bug-report for combine

Seth Falcon sfalcon at fhcrc.org
Wed Jul 18 17:07:57 CEST 2007


Hi Laurent,

"Laurent Gautier" <lgautier at gmail.com> writes:
> It seems to be a problem with 'identical'.
>
> The following patched "combine" seems to fix the problem
> (workaround for zero-rows data.frames:
> length(sharedRows) == 0))
> )

Thanks for the report and the fix.  Would you be willing to resend as
a real patch?  By that I mean:
   - make the change in an up to date svn working copy of Biobase
   - send output of 'svn diff'

We should also add your test case to the unit tests in inst/UnitTests

+ seth

-- 
Seth Falcon | Computational Biology | Fred Hutchinson Cancer Research Center
http://bioconductor.org



More information about the Bioc-devel mailing list