[R-SIG-Mac] Phantom Text

[Simon Urbanek]

On Jan 20, 2013, at 7:04 PM, Hans-Jörg Bibiko wrote:

> 
> On Jan 21, 2013, at 12:27 AM, Joseph Coyle wrote:
> 
>> Regarding the phantom text problem I have had a poke around the subversion tree and found that the bug was introduced in the subversion commit from 28 August 2012 10:02:49 GMT+01:00.   Specifically the method:  - (void)textStorageDidProcessEditing:(NSNotification *)notification from RScriptEditorTextView was altered to comment out the if statement shown below which serves to interrupt the syntax highlighting on large text blocks to improve performance. 
>> 
>> 		if([[theTextStorage string] length] > 120000) {
>> 			breakSyntaxHighlighting = 1;
>> 		}
>> 
>> The line below was then added presumably as a temporary test. 
>> 
>> breakSyntaxHighlighting = 1;
> 
> Hi Joseph,
> 
> thanks for the effort!
> 
> Indeed, I found out that the syntax highlighting parser was responsible for this "phantom" text caused by an uncaught output of the underlying lex parser. Today I've already sent Simon my patch thus in the next release this "phantom" will disappear.
> 

Yes, it's now committed and I can confirm that it fixes the issue. I have also committed the fix for startup drag'n'drop behavior. Both should be available in tomorrow's daily build (or you can get it form the SVN right now).

Cheers,
Simon