[R-sig-DB] [PATCH] segfault in RSQLite 0.5-4

[Seth Falcon]

"Ashish Kulkarni" <ashish.kulkarni using kalyptorisk.com> writes:
> Upon further investigation, I think that this test falls in a grey area.
> The error returned by SQLite is actually "table not found". 
> The use case for schema reload is already in testSchemaChangeDuringQuery() 
> and the patched code successfully passes it. In fact, I experimented with
> adding a column to the same table against which the query was prepared,
> and it worked. 

Adding such an experiment to the test cases would be most helpful. :-)

> The test checks for something else: whether a table added in one connection
> is immediately visible in another connection. Leaving aside the fact that
> this would be a very rare scenario, I think that SQLite should reload
> the schema information before reporting "table not found", which it is
> not doing so for sqlite3_prepare_v2. I will try to follow it up upstream,
> but may not be able to do so soon as I will out for 2 weeks.
>
> Either way, what we are testing for is not a very common scenario: the 
> normal scenario of schema reload/recompilation *is* handled properly.
> I've removed the test in the updated patches, we should make a call
> whether to re-include it with renaming to 
> testTableAddedVisibleInOtherConnection()

How about renaming the test and using RUnit's DEACTIVATED().  This
way, the tests will run, but we'll be reminded to follow up on this.

Would you be willing to redo/add to your patch by adding the "add
column" test and the above rename/DEACTIVATE?

+ seth

-- 
Seth Falcon | Computational Biology | Fred Hutchinson Cancer Research Center
http://bioconductor.org