[R-sig-DB] [PATCH] segfault in RSQLite 0.5-4

[Seth Falcon]

"Ashish Kulkarni" <ashish.kulkarni using kalyptorisk.com> writes:

> Seth Falcon wrote:
>
>> I'm a bit surprised by this choice.  Can you explain why integer is
>> the desired default?  I was expecting to see SQLITE_TEXT here -- if
>> you don't know what a column in a result set is, you can always put it
>> into a character vector in R, you cannot always convert it to
>> integer.  Or am I missing something?
>> 
>
> Yep, you're right -- my scenario involved an integer, but I agree that
> SQLITE_TEXT is the more generic option :-)

ok, glad we are on the same page.

>> The problem is that whenever a result set has a column with a NULL in
>> the first row, the type will be forced to text.  I can think of ways
>> of fixing this, but the solutions add complexity and will likely hurt
>> performance.  I wonder if anyone has a suggestion here?  One idea is
>> to provide a mechanism for users to specify the desired types of the
>> columns in a resultset.
>
> The patch fixes my problem. Also, what you describe is very much of an 
> edge case, so I think we can leave it unaddressed at the moment.

Thanks for testing and getting back to me.  I plan to send out an
update to CRAN later today or early tomorrow.
>
> BTW, the version of SQLite we bundle (3.3.8) is rather old, 3.4.0 being
> the new version. Also, considering that this version introduces a simple
> way of embedding SQLite in any other application, we should look into 
> that approach: see http://www.sqlite.org/cvstrac/wiki?p=TheAmalgamation
>
> It would reduce the source package size, increase the speed a bit and 
> standardize the build process across *nix and Windows.

I've seen that and had the same thought.  I plan to include the new
version in the update ASAP because of a bug in SQLite reported by
Gabor.  I will see about using the "Amalgamation" since, as you say,
should simplify the build on Windows.

Best,

+ seth

-- 
Seth Falcon | Computational Biology | Fred Hutchinson Cancer Research Center
http://bioconductor.org