[R-pkg-devel] [EXTERN] cran check about examples time
Fellinger Tobias
tob|@@@|e|||nger @end|ng |rom @ge@@@t
Thu Apr 17 09:27:49 CEST 2025
Dear Emanuele,
I checked one of the Notes. One of the examples of get.geotop.inpts.keyword.value that throws a NOTE has parts outside of donttest that seem to load data from an url which can lead to varying execution times depending on the server. Moreover the url seems not to work. (https://raw.githubusercontent.com/ecor/geotopbricks_doc/master/simulations/panola13_run2xC_test3)
If you want to load the data from the web, I'd also put this in a donttest section.
An alternative would be (if this makes sense for the example) to include the file in the package and load it with system.file in the examples. This should run faster and more reliable and be independent of changes to URLs outside of the repository. Beware of maximum package sizes though.
(I checked this with the current default branch on github.)
Hope this helps, best regards, Tobias
-----Ursprüngliche Nachricht-----
Von: R-package-devel <r-package-devel-bounces using r-project.org> Im Auftrag von Emanuele Cordano
Gesendet: Montag, 14. April 2025 08:54
An: r-package-devel using r-project.org
Betreff: [EXTERN] [R-pkg-devel] cran check about examples time
[You don't often get email from emanuele.cordano using gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
Dear list,
I'm submitting the following package. CRAN check were OK (frorr Windows)
whereas in Debian a function example elapses 5.326 seconds. I need to
fix this. Most lines in the examples are within \donttest{} brackets, so they should not be executed by CRAN checks. The examples are useful to understand the functions, as they are, should I include all examples lines in \donttest{} or \dontrun{} ?
Do you have any suggestion or reference on this? CRAN message attached below.
Thank you
Best
Emanuele Cordano
CRAN message:
Dear maintainer,
package geotopbricks_1.5.9.1.tar.gz does not pass the incoming checks automatically, please see the following pre-tests (additional issue checks):
Windows: <
https://win-builder.r-project.org/incoming_pretest/geotopbricks_1.5.9.1_20250413_174815/Windows/00check.log
>
Status: OK
Debian: <
https://win-builder.r-project.org/incoming_pretest/geotopbricks_1.5.9.1_20250413_174815/Debian/00check.log
>
Status: 1 NOTE
Last released version's CRAN status: OK: 9, NOTE: 5
See: <https://cran.r-project.org/web/checks/check_results_geotopbricks.html>
CRAN Web: <https://cran.r-project.org/package=geotopbricks>
Please fix all problems and resubmit a fixed version via the webform.
If you are not sure how to fix the problems shown, please ask for help on the R-package-devel mailing list:
<https://stat.ethz.ch/mailman/listinfo/r-package-devel>
If you are fairly certain the rejection is a false positive, please reply-all to this message and explain.
More details are given in the directory:
<
https://win-builder.r-project.org/incoming_pretest/geotopbricks_1.5.9.1_20250413_174815/
>
The files will be removed after roughly 7 days.
No strong reverse dependencies to be checked.
Best regards,
CRAN teams' auto-check service
Flavor: r-devel-windows-x86_64
Check: *, Result: OK
Flavor: r-devel-linux-x86_64-debian-gcc
Check: examples, Result: NOTE
Examples with CPU (user + system) or elapsed time > 5s
user system elapsed
get.geotop.inpts.keyword.value 1.406 0.027 5.326
[[alternative HTML version deleted]]
______________________________________________
R-package-devel using r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel
[https://www.ages.at/fileadmin/Signatur/03_AGES_Mailsignatur2025_Zeichenflaeche_1-04.png]<https://www.ages.at/ages/one-health/one-health>
________________________________
Firma & Rechtsform: Österreichische Agentur für Gesundheit und Ernährungssicherheit GmbH
Sitz: Spargelfeldstraße 191, 1220 Wien
Firmenbuchnummer: FN 223056z
Firmenbuchgericht: Handelsgericht Wien
Diese Nachricht und allfällige angehängte Dokumente sind vertraulich und nur für den/die Adressaten bestimmt. Sollten Sie nicht der beabsichtigte Adressat sein, ist jede Offenlegung, Weiterleitung oder sonstige Verwendung dieser Information nicht gestattet. In diesem Fall bitten wir, den Absender zu verständigen und die Information zu vernichten. Für Übermittlungsfehler oder sonstige Irrtümer bei Übermittlung besteht keine Haftung.
Unsere Datenschutzerklärung finden Sie unter: Datenschutzerklärung<https://www.ages.at/datenschutzerklaerung>
This message and any attached files are confidential and intended solely for the addressee(s). Any publication, transmission or other use of the information by a person or entity other than the intended addressee is prohibited. If you receive this in error please contact the sender and delete the material. The sender does not accept liability for any errors or omissions as a result of the transmission.
You can find our privacy policy at: privacy policy<https://www.ages.at/en/privacy>
More information about the R-package-devel
mailing list