[R-pkg-devel] Warnings from upstream C library in CRAN submission

[Jeff Newmiller]

Type conversions are always a bit risky... this one appears to be likely to corrupt data. If they actually intended to truncate values like this then they should have cast explicitly.

Looks like you need to report this to the SUNDIALS maintainers.

On February 3, 2024 7:38:35 AM PST, Satyaprakash Nayak <sn248 using cornell.edu> wrote:
>Hi
>
>I had a package 'sundialr' which was archived from CRAN. It is an interface
>to some of the solvers in SUNDIALS ODE Solving library. I have fixed the
>issue which was related to emails being forwarded from the maintainer's
>email address.
>
>The repository code can be found at - https://github.com/sn248/sundialr
>
>I have updated the upstream library and now I am getting the following
>warnings from CRAN which are all related to the upstream library. The
>package compiles without any other issues and can be used.
>
>Flavor: r-devel-windows-x86_64
>Check: whether package can be installed, Result: WARNING
>  Found the following significant warnings:
>    ./sundials/sundials/sundials_hashmap.h:26:48: warning: conversion from
>'long long unsigned int' to 'long unsigned int' changes value from
>'14695981039346656037' to '2216829733' [-Woverflow]
>    ./sundials/sundials/sundials_hashmap.h:27:48: warning: conversion from
>'long long unsigned int' to 'long unsigned int' changes value from
>'1099511628211' to '435' [-Woverflow]
>    sundials/sundials/sundials_hashmap.h:26:48: warning: conversion from
>'long long unsigned int' to 'long unsigned int' changes value from
>'14695981039346656037' to '2216829733' [-Woverflow]
>    sundials/sundials/sundials_hashmap.h:27:48: warning: conversion from
>'long long unsigned int' to 'long unsigned int' changes value from
>'1099511628211' to '435' [-Woverflow]
>    sundials/sundials/sundials_profiler.c:71:24: warning: function
>declaration isn't a prototype [-Wstrict-prototypes]
>  See 'd:/RCompile/CRANincoming/R-devel/sundialr.Rcheck/00install.out' for
>details.
>  Used C++ compiler: 'g++.exe (GCC) 12.3.0'
>
>Flavor: r-devel-linux-x86_64-debian-gcc
>Check: whether package can be installed, Result: WARNING
>  Found the following significant warnings:
>    sundials/sundials/sundials_profiler.c:71:41: warning: a function
>declaration without a prototype is deprecated in all versions of C
>[-Wstrict-prototypes]
>  See '/srv/hornik/tmp/CRAN/sundialr.Rcheck/00install.out' for details.
>  Used C++ compiler: 'Debian clang version 17.0.6 (5)'
>
>I am hesitant to change anything in the SUNDIALS library C code because I
>don't understand the consequences of changing anything there.
>
>Any help will be kindly appreciated.
>
>Thank you.
>
>	[[alternative HTML version deleted]]
>
>______________________________________________
>R-package-devel using r-project.org mailing list
>https://stat.ethz.ch/mailman/listinfo/r-package-devel

-- 
Sent from my phone. Please excuse my brevity.