[R-pkg-devel] doi confusion and Data codoc mismatches-confusing check

[Spencer Graves]

Hello, All:


	  The latest checks on 
"https://github.com/sbgraves237/Ecdat/runs/4634725654?check_suite_focus=true" 
identify two problems I don't know how to fix:


FIRST:  Data codoc mismatches from documentation object 'USnewspapers':
   Variables in data frame 'USnewspapers'
     Code: AdsProportion Ads_G2012dollars Ads_currentGdollars
           Circ_G2012dollars Circ_currentGdollars GDP_G2012 GDP_nominalG
           Population_M RevenuePerCap_2012 RevenuePerCap_nominal
           Revenue_G2012dollars Revenue_currentGdollars Year
           newspapers_p_GDP
     Docs: Ads_G2012dollars Circ_G2012dollars Circ_currentGdollars
           Revenue_G2012dollars Revenue_currentGdollars AdsProportion
           Ads_currentGdollars GDP_G2012 GDP_nominalG Population_M
           RevenuePerCap_2012 RevenuePerCap_nominal Year newspapers_p_GDP


	  I believe that the column names in the data.frame 'USnewspapers' 
match the names in the order given in the *.Rd file and the variable 
list following "Code" here matches that following "Docs" using, e.g., 
sort(scan(what=character())).


SECOND:  Found the following URLs which should use \doi (with the DOI 
name only):
     File 'AccountantsAuditorsPct.Rd':
       https://doi.org/10.18128/D010.V8.0
     File 'OCC1950.Rd':
       https://doi.org/10.18128/D010.V10.0


	  My concern here is that these two urls are in, e.g., 
\href{https://doi.org/10.18128/D010.V8.0}{text to display to click to 
link to the doi url}.  If it were, e.g., 
\url{https://doi.org/10.18128/D010.V8.0} I would try replacing it with 
\doi{10.18128/D010.V8.0}.  However, if I do that, I don't know what to 
do with the "text to display to click to link to the doi url".


NOTE:  I tried changing \href{}{} to \doi{}{} in 
'AccountantsAuditorsPct.Rd' and got what I expected:  First, I failed to 
mention before that this complaint does NOT appear in R CMD check on my 
local computer;  see sessionInfo() below.  when I checked how that doi 
reference displayed in Ecdat-manual.pdf, I found that "doi: 
10.18128/D010.V8.0" was displayed, followed by the "text to display to 
click to link to the doi url".


Specifically, I got:


Steven Ruggles, Sarah Flood, Ronald Goeken, Josiah Grover, Erin Meyer, 
Jose Pacas, and Matthew Sobek (2018) doi: 10.18128/D010.V8.0IPUMS USA: 
Version 8.0 [dataset]. Minneapolis, MN: IPUMS.


	  With \href{}{}, "doi: 10.18128/D010.V8.0" does not appear, and I get 
that URL by clicking on "IPUMS USA: Version 8.0 [dataset]. Minneapolis, 
MN: IPUMS."  With this version, clicking on "IPUMS USA: Version 8.0 
[dataset]. Minneapolis, MN: IPUMS." does nothing, whild clicking on 
"doi: 10.18128/D010.V8.0" takes me to that URL.


	  This looks like a change to how *.Rd files are rendered that has 
appeared in the process on GitHub but not in my local computer.  ???


	  Thanks,
	  Spencer Graves


 > sessionInfo()
R version 4.1.2 (2021-11-01)
Platform: x86_64-apple-darwin17.0 (64-bit)
Running under: macOS Big Sur 11.6.2

Matrix products: default
LAPACK: 
/Library/Frameworks/R.framework/Versions/4.1/Resources/lib/libRlapack.dylib

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets
[6] methods   base

loaded via a namespace (and not attached):
[1] compiler_4.1.2 tools_4.1.2