[Rd] xftrm is more than 100x slower for AsIs than for character vectors

HB ju0815nk @end|ng |rom gmx@net
Sun Jul 14 19:09:34 CEST 2024


Dear Ivan, 

thanks for the confirmation and the proposed patch. 

I just wanted to add some notes regarding the relevance of this: base::merge using by.x=0 or by.y=0 (i.e. matching on row.names) will automatically add a column Row.names which is I(row.names(x)) to the corresponding input table (using I() since  revision 39026 to avoid conversion of character to factor). When this column is used for sorting (sort=TRUE by default in merge; should happen at least if all.x=T or all.y=T), this will result in slower execution. 

xtfrm.AsIs is unchanged since its addition in r50992 (likely unrelated to the former). 

So I guess that this just went unnoticed since it will not cause problems on small data frames.

Best regards

Hilmar
 
	[[alternative HTML version deleted]]



More information about the R-devel mailing list