[Rd] [PATCH] Makefile: add support for git svn clones
edd at debian.org
Mon Jan 19 23:35:31 CET 2015
On 19 January 2015 at 17:11, Duncan Murdoch wrote:
| The people who would have to maintain the patch can't test it.
I don't understand this.
The patch, as we may want to recall, was all of
+GIT := $(shell if [ -d "$(top_builddir)/.git" ]; then \
+ echo "git"; fi)
- (cd $(srcdir); LC_ALL=C TZ=GMT svn info || $(ECHO) "Revision: -99") 2> /dev/null \
+ (cd $(srcdir); LC_ALL=C TZ=GMT $(GIT) svn info || $(ECHO) "Revision: -99") 2> /dev/null \
I believe you can test that builds works before applying the patch, and
afterwards---even when you do not have git, or in this case a git checkout.
The idiom of expanding a variable to "nothing" if not set is used all over
the R sources and can be assumed common. And if (hypothetically speaking)
the build failed when a .git directory was present? None of R Core's concern
either as git was never supported.
I really do not understand the excitement over this. The patch is short,
clean, simple, and removes an entirely unnecessary element of friction.
http://dirk.eddelbuettel.com | @eddelbuettel | edd at debian.org
More information about the R-devel