[Rd] [PATCH] Makefile: add support for git svn clones

[Duncan Murdoch]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 19/01/2015 3:20 PM, Felipe Balbi wrote:
> Hi,
> 
> On Mon, Jan 19, 2015 at 03:06:11PM -0500, Duncan Murdoch wrote:
>> On 19/01/2015 2:33 PM, Felipe Balbi wrote:
>>> git has an interface for cloning SVN repositories into git 
>>> which some users might decide to use. For those users' 
>>> surprise, the repository will always fail to build on svnonly 
>>> target and it will exit early.
>>> 
>>> The problem is simple enough to fix by just checking if a .git
>>>  directory exists in top_builddir and, if so, call git svn
>>> info insstead of svn info.
>>> 
>> 
>> I think we are unlikely to accept this change.  Nobody in R Core 
>> uses git this way, so it would never be tested, and would likely 
>> soon fail.
> 
> it will be tested by anybody using git svn clone, right ?
> 
>> Indeed, it already fails if someone were to try it on Windows, 
>> since you didn't patch the makefiles for that platform.
> 
> yeah, sorry about that, I wasn't aware there were windows-specific
>  Makefiles with duplicated logic in the repository.
> 
>> The R sources are kept in an SVN repository, and as long as 
>> that's true, we're only likely to support direct SVN access.
> 
> Fair enough. But don't you think it's a bit odd to couple the 
> repository compilation with the availability of a specific SCM
> tool ?
> 
> I mean, R just won't build unless you have svn info available, I 
> think that's pretty odd. Printing a warning would be another 
> possibility, but exitting build is almost an overreaction.

That's just false.  Build from a tarball, and you can store it anyway
you like.

Duncan Murdoch

> 
> But fair enough, no need to spend days discussing $subject if the 
> community doesn't want to support git svn clone ;-)
> 
> cheers
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: GPGTools - https://gpgtools.org

iQEcBAEBCgAGBQJUvWmkAAoJEHE2Kz23YMZyRJYIALwb51h1lpauxg3UN5gTzZg6
LIDyvK0s40wfVrXFLTPq43Zvisuzkp55+o2/3GMUDNjXqgESkODtk/uRBaMdON+b
875mzqNVYHGs3a2oGMlDpZJ3qfVmb4vdNPs7G6T5xuz+Xx29RjchKCWUFZ6L96y9
r69yYTh/18dlGk1KogwLdEfT2x+4qC4cukJ4YBuphY0gdm+zO6U/fsfsN1NG6bi5
Ogt89RslpMdKZ4sIG55XiW2S9qK2BJgXhlb2Lf/+sbkoXFOXsX3LVC3fLWr3gQtY
Ll+h2NW9fC2fHxXsECHY47sVtVV6kY5MQM3xWkJ9BIYN7Bw1glAdJS3NHNpqJzI=
=pxOh
-----END PGP SIGNATURE-----