[Rd] Patch proposal for R style consistency (concerning deparse.c)

Hervé Pagès hpages at fhcrc.org
Thu May 2 01:49:49 CEST 2013


On 05/01/2013 12:19 PM, Duncan Murdoch wrote:
> On 01/05/2013 1:34 PM, Tim Triche, Jr. wrote:
>> +1 to having runnable code emitted
>
> It does emit runnable code, which is why Herve's complaint was
> nonsense.  It doesn't emit code of which every substring is runnable.

Perdon me, but I was not of course suggesting that every substring be
runnable. That would be non-sense. So please, don't make me say what
I didn't say. Thank you!

H.

>
> Duncan Murdoch
>
>>
>> patch seems to work nicely, hopefully R-core will agree to apply it to
>> HEAD
>>
>>
>>
>> On Wed, May 1, 2013 at 9:45 AM, Paul Johnson <pauljohn32 at gmail.com>
>> wrote:
>>
>> > Whoa.
>> >
>> > Don't let my valuable suggestion get lost.
>> >
>> >  I want "} else {".  Yihue wants "} else {".  And I have not heard
>> anybody
>> > say they prefer the other way, unless you interpret Duncan's comment
>> > "that's nonsense" as a blanket defense of the status quo. But I
>> don't think
>> > he meant that.  This is a matter of style consistency and avoidance
>> of new
>> > R-user confusion and error.
>> >
>> > After reading the help for "if", I don't see how anybody can argue
>> against
>> > this.  Good R code has this style:
>> >
>> > } else {
>> >
>> > and not
>> >
>> > }
>> >  else
>> >
>> > because the latter fails if it is run line-by-line.  While trying to
>> teach
>> > people how to write R programs, it would be nice if the output of
>> > print.function was consistent with the good way, the way that is
>> actually
>> > practiced in the R source code itself. This is a major source of new
>> > programmer confusion. Its very tough to explain and teach.
>> >
>> > pj
>> > --
>> > Paul E. Johnson
>> > Professor, Political Science      Assoc. Director
>> > 1541 Lilac Lane, Room 504      Center for Research Methods
>> > University of Kansas                 University of Kansas
>> > http://pj.freefaculty.org               http://quant.ku.edu
>> >
>> >         [[alternative HTML version deleted]]
>> >
>> > ______________________________________________
>> > R-devel at r-project.org mailing list
>> > https://stat.ethz.ch/mailman/listinfo/r-devel
>> >
>>
>>
>>
>
> ______________________________________________
> R-devel at r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel

-- 
Hervé Pagès

Program in Computational Biology
Division of Public Health Sciences
Fred Hutchinson Cancer Research Center
1100 Fairview Ave. N, M1-B514
P.O. Box 19024
Seattle, WA 98109-1024

E-mail: hpages at fhcrc.org
Phone:  (206) 667-5791
Fax:    (206) 667-1319



More information about the R-devel mailing list