[Rd] Problem with WARNING...headers with CRLF line endings

[Duncan Murdoch]

On 14/09/2010 6:08 PM, Hervé Pagès wrote:
> On 09/14/2010 02:58 PM, cstrato wrote:
>> Dear Herve,
>>
>> Thank you for your reply, however maybe I was not quite clear.
>>
>> The files xpsDict.h and xpsDict.cxx are automatically created by the
>> ROOT framework during compilation on every architecture.
> 
> on every architecture... ok
> But if they are created during compilation, why do they need to be
> included in the source tarball? They are just temporary files right?
> Or I'm missing something...
> 
>> This means they
>> are created on Linux and Mac with LF line endings, but on Windows with
>> CRLF line endings. However, they are created only if they do not already
>> exist, and thus are not in the source tarball.
> 
> I guess you mean they are not part of the source *tree*.
> 
>> For testing purposes I have just added both files with LF line endings
>> to the source tarball and compiled it on Windows w/o problems.
>> Furthermore, the size of "xps_1.9.6.tar.gz" increases only from 4MB to
>> 4.3MB. Thus in principle I could upload both files to SVN for BioC 2.7,
>> and this should eliminate the warning message. What is your opinion?
> 
> I still don't understand why you want to have them in the source
> tarball.

I think he doesn't want to put them in the source tarball, but because 
of the way R CMD check works, he may have to.

It appears that R CMD check builds those files, and then checks for CRLF 
endings on all files.  If it did the CRLF check first, it wouldn't see 
them and complain.  The problem with this change is that some packages 
might create files with CRLF endings on all platforms, and then check 
*should* complain about them.

My advice would be not to put them in the tarball, and ignore the 
warning.  Or write a Makevars.win that fixes the line endings so that 
check is happy.

Duncan Murdoch