[Rd] 'make install' fails on Solaris (PR#13946)

[Peter Dalgaard]

Prof Brian Ripley wrote:
> On Thu, 10 Sep 2009, bownes at gmail.com wrote:
> 
>> Full_Name: Bob Bownes
>> Version: 2.9.2
>> OS: Solaris 10
>> Submission from: (NULL) (164.55.254.106)
>>
>>
>> The sed lines in src/unix/Makefile confuse the grep distributed with 
>> Solaris
>> that gets configured by ./configure.
> 
> Well, it calls sed not grep!  Which version was that -- it works for me 
> and for several others.  I have SED = /usr/xpg4/bin/sed (see file 
> Makeconf), and that is 'distributed with Solaris': perhaps you do not 
> have it installed?
> 
> The danger of changing R to fix a broken OS tool is that the change may 
> break on other people's tools -- better to fix the tool.


Is this a tool problem at all? The most common reason for separator 
breakage is that one of the substitution strings contains the separator.

E.g., the sed line may break if  @rhome contains a colon, and after the 
fix it will break if it contains a comma...

> 
> 
>> Switching from a separator of ':' to a separator of ',' fixes the 
>> problem.
>>
>> 76,77c76,77
>> <       @$(SED) -e "s:@rhome:$(rhome):" -e 
>> "s:@rincludedir:$(rincludedir):" \
>> <         -e 's:@libsprivate:$(STATIC_LIBR_PC):' \
>> ---
>>>       @$(SED) -e "s, at rhome,$(rhome)," -e 
>>> "s, at rincludedir,$(rincludedir)," \
>>>         -e 's, at libsprivate,$(STATIC_LIBR_PC),' \
> 


-- 
    O__  ---- Peter Dalgaard             Øster Farimagsgade 5, Entr.B
   c/ /'_ --- Dept. of Biostatistics     PO Box 2099, 1014 Cph. K
  (*) \(*) -- University of Copenhagen   Denmark      Ph:  (+45) 35327918
~~~~~~~~~~ - (p.dalgaard at biostat.ku.dk)              FAX: (+45) 35327907