[Rd] R-2.3.1 does not install on FreeBSD 4.11-RELEASE (PR#8971)

[kenji.rikitake at acm.org]

Full_Name: Kenji Rikitake
Version: 2.3.1
OS: FreeBSD 4.11-RELEASE-p18
Submission from: (NULL) (220.157.163.221)


After doing
./configure --disable-mbcs
(as default in FreeBSD 4.x)
and
make
the compilation stops at src/main/printutils.c as:
printutils.c: In function `Rvprintf':
printutils.c:582: `va_start' used in function with fixed args
printutils.c:591: syntax error before `}'

the following patch includes two fixes:

1) removing unnecessary va_start() and va_end() macro for Rvprintf() in
   src/main/printutils.c
2) fixing error by adding {} around calling error() in src/main/printutils.c

--- src/main/printutils.c.FCS   Mon Apr 10 07:19:28 2006
+++ src/main/printutils.c       Tue Jun 13 12:07:05 2006
@@ -579,14 +579,15 @@
       (con->vfprintf)(con, format, argcopy);
       va_end(argcopy);
 #else /* don't support sink(,split=TRUE) */
-      va_start(arg, format);
+      /* va_start(arg, format); */ /* not for FREEBSD_4 */
       (con->vfprintf)(con, format, arg);
-      va_end(arg);
+      /* va_end(arg); */
+      /* not for FREEBSD_4 */
 #endif
       con->fflush(con);
       con_num = getActiveSink(i++);
 #ifndef HAVE_VA_COPY
-      if (con_num>0) error("Internal error: this platform does not support
split output")
+      if (con_num>0) {error("Internal error: this platform does not support
split output");}
 #endif
     } while(con_num>0);
 
Also, I needed to fix the permission after doing
make install
using the following set of commands:

cd /usr/local/lib/R/exec
chmod 0755 R
cd /usr/local/lib/R/lib
chmod 0755 libRlapack.so
cd /usr/local/lib/R/base
chmod 755 Meta R R-ex demo help html latex man po
find . -type d -not -perm -001 | xargs chmod go+rx
find . -type f -and -not -perm -444 | xargs chmod go+r
cd /usr/local/lib/R/modules
chmod 755 *.so

[End of bug report]