[Rd] install of grid fails in R-1.7.0beta_2003-03-29

[ripley at stats.ox.ac.uk]

On Sat, 29 Mar 2003 ripley at stats.ox.ac.uk wrote:

> On Sat, 29 Mar 2003, Uwe Ligges wrote:
> 
> > Hi,
> > 
> > I'm just compiling R-1.7.0beta_2003-03-29.tar.gz on WinNT 4.0:
> > 
> > the installation of package grid fails (at least the build of help files):
> > 
> > ---------- Making package grid ------------
> >    installing inst files
> >    adding build stamp to DESCRIPTION
> >    making DLL ...
> >    ... DLL made
> >    installing R files
> >    installing man source files
> >    installing indices
> > Error in !.listFilesWithType(vignetteDir, "vignette") :
> >          invalid argument type
> > Execution halted
> > make[1]: *** [indices] Error 1
> > make: *** [pkg-grid] Error 2
> > *** Installation of grid failed ***
> > 
> > 
> > Is this known or is it worth to debug?
> 
> Yes, but it *had* been fixed, and I've just encountered it again.
> So I will be debugging it.  The problem is that grid installs a PDF file 
> in doc which is not a vignette.

in tools/admin.R it should be

.installPackageVignetteIndex <-
function(dir, outDir)
{
    vignetteDir <- file.path(dir, "inst", "doc")
    ## Create a vignette index only if the vignette dir exists and
    ## really contains vignettes.
    if(!.fileTest("-d", vignetteDir)) return()
    if(!length(.listFilesWithType(vignetteDir, "vignette"))) return()
        ^^^^^^^                                           ^ 

The result of .listFilesWithType is a character string,
so this would never work: under Unix the result of the R invocation was
never tested.

-- 
Brian D. Ripley,                  ripley at stats.ox.ac.uk
Professor of Applied Statistics,  http://www.stats.ox.ac.uk/~ripley/
University of Oxford,             Tel:  +44 1865 272861 (self)
1 South Parks Road,                     +44 1865 272866 (PA)
Oxford OX1 3TG, UK                Fax:  +44 1865 272595