[ESS] Change in ESS affects Org generating images through R session

Lionel Henry ||one|@hry @end|ng |rom gm@||@com
Sat Apr 9 00:18:44 CEST 2016


The single quote takes care of the org issue, and the ess-quote-special-chars
addresses the eval-function issue.

Now fixed on master.

Lionel


> On 9 avr. 2016, at 00:00, Vitalie Spinu <spinuvit using gmail.com> wrote:
> 
> 
> Yep. The recent eval cleanup dropped ess-quote-special-chars inadvertently. The
> `string` argument must be wrapped in it.
> 
> I think the same should apply to ess-r-build-load-command.
> 
>  Vitalie
> 
>>> On Fri, Apr 08 2016 23:11, Lionel Henry wrote:
> 
>>> On 8 avr. 2016, at 23:10, Charles C. Berry <ccberry using ucsd.edu> wrote:
>>> 
>>> On Fri, 8 Apr 2016, Vitalie Spinu wrote:
>>> 
>>>>>> On Fri, Apr 08 2016 21:35, Lionel Henry wrote:
>>>> 
>>>>> I think this is linked to https://github.com/emacs-ess/ESS/issues/314>>> <https://github.com/emacs-ess/ESS/issues/314>>> 
>>>> I don't think so. It concerns buffer evaluation only.
>>>> 
>>> 
>>> I think the culprit is `ess-r-build-eval-command' which both ess-eval-buffer and ess-eval-function rely on.
>>> 
>>> The failures occur because of single quotes in `string' in each case here:
>>> 
>>> (concat cmd "('" string "'" args file ")\n")))
> 
>> Exactly.
> 
>> I'm struggling a bit with the new unit test macros. Will upload a fix soon.
> 
>> Lionel




More information about the ESS-help mailing list