[ESS] ess patch: avoid (error "Invalid buffer")

Vitalie Spinu spinuvit at gmail.com
Mon Feb 27 20:37:07 CET 2012


Thanks Sam, 

Fixed in SVN.

Vitalie.

>>>> Sam Steingold <sds at gnu.org>
>>>> on Mon, 27 Feb 2012 12:26:38 -0500 wrote:

  > The following message is a courtesy copy of an article
  > that has been posted to gmane.emacs.ess.general as well.

  >> * Vitalie Spinu <fcvahivg at tznvy.pbz> [2012-02-27 18:12:50 +0100]:
  >> 
  >> Thanks for the catch, it's applied now.

  > you are welcome.

  > also, you probably want to bind keys to kill-this-buffer, not kill-buffer:

  > Index: ess-help.el
  > ===================================================================
  > --- ess-help.el	(revision 4654)
  > +++ ess-help.el	(working copy)
  > @@ -550,7 +551,7 @@ For internal use. Used in `ess-display-h
  >    (define-key ess-help-mode-map ">" 'end-of-buffer)
  >    (define-key ess-help-mode-map "<" 'beginning-of-buffer)
  >    (define-key ess-help-mode-map "x" 'ess-kill-buffer-and-go)
  > -  (define-key ess-help-mode-map "k" 'kill-buffer)
  > +  (define-key ess-help-mode-map "k" 'kill-this-buffer)
  >    (define-key ess-help-mode-map "?" 'ess-describe-help-mode)
  >    ;;-- those should be "inherited" from ess-mode-map ( ./ess-mode.el )
  >    (define-key ess-help-mode-map "\C-c\C-s" 'ess-switch-process)
  > @@ -593,7 +594,7 @@ For internal use. Used in `ess-display-h
  >  	"-"
  >  	["Describe ESS-help Mode"	ess-describe-help-mode t]
  >  	"-"
  > -	["Kill Buffer"			kill-buffer t]
  > +	["Kill Buffer"			kill-this-buffer t]
  >  	["Kill Buffer & Go"		ess-kill-buffer-and-go t]
  >  	)
  >    "Menu used in ess-help mode.")



More information about the ESS-help mailing list