[ESS-bugs] ESS 13.09-1 with old R versions fails pretty badly

[Vitalie Spinu]

Hi Martin, 

Nice job. Thanks. 

This is quite a change, so we will have to postpone the release for yet
another week.

I have a couple of concerns so far. 


     @@ -87,6 +89,9 @@ distclean: clean
      ess-custom.el: ../VERSION
      	perl -pi -e 's/".*"/"$(ESSVERSION)"/ if /ess-version/' $@
      
     +ess-r-d.el: ../etc/ESSR-VERSION
     +	sed -i -e '/let.*ESSR-version/s/"[-.0-9]*"/"$(ESSR_VER)"/' $@
     +
      
      (defun ess--R-load-ESSR ()
     -  "LOAD/INSTALL/UPDATE ESSR"
     -  (let* ((ESSR-version "1.0.1") ; <- FIXME: smart way to automate this?
     +  "Load/INSTALL/Update ESSR"
     +  (let* ((ESSR-version "1.0.2") ; <- This is auto-updated via make
               (up-to-date (ess-boolean-command


This will not work for those who don't build. It will also not work with
MELPA. I will fix that by parsing the ESSR/DESCRIPTION directly.


     
     all: ESSR-VERSION $(ESSR_tarball) library/ESSR
     
     ## happens "above" as it is need also in ../lisp/ :
     ESSR-VERSION: $(ESSR_FILES)
     	(cd .. ; make etc/ESSR-VERSION)
     
     $(ESSR_tarball): $(ESSR_FILES)
     	R CMD build ESSR 
     library/ESSR: $(ESSR_tarball)
     	R CMD INSTALL -l library ESSR
     

So we are switching to ESS specific library? Good. But, it should work
also without make, and that means that we need to ship library/ESSR with
SVN. This pre-installed version should be built with a reasonably old
version of R like 2.15 or even 2.14. Otherwise, as you pointed out last
time, users will see warnings.


  Vitalie



 >>> Martin Maechler on Tue, 29 Oct 2013 19:49:15 +0100 wrote:

 > I've worked on this,  but got "hung up" on the FIXME in
 >      ess-r-d.el
 > to autogenerate the ESSR package version number used there,
 > and committed my current changes... should be working but
 > are unfinished, notably for the first simple workaround source()
 > workaround.

 > More is planned in two days only (as I have to prepare other
 > stuff urgently for Thursday morning and am already busy with
 > something else a big part of tomorrow).

 > Martin

 > _______________________________________________
 > ESS-bugs ESS-bugs at r-project.org
 > https://stat.ethz.ch/mailman/listinfo/ess-bugs

 > _______________________________________________
 > ESS-core list: https://stat.ethz.ch/mailman/listinfo/ess-core