[ESS-bugs] ess-mode 13.09 [git: e9a3e4c08e01f40923d67d6d581f8fe67fb1b44a]; error while typing in an R buffer

[Vitalie Spinu]

I see the error. It happens when ess-eldoc-show-on-symbol is t. The
default is nil and this is why nobody reported this so far.

I have corrected it on my local branch, will push it shortly.

Thanks a lot, 

  Vitalie

 >>> Sam Steingold on Sat, 21 Sep 2013 20:03:11 -0400 wrote:

 > Whether you see the error or not, the use of `symbol-at-point` to
 > extract a _string_ is _wrong_.

 > On Thu, Sep 19, 2013 at 3:41 PM, Vitalie Spinu <spinuvit at gmail.com> wrote:
 >> 
 >> Strange, why I don't see the bug then. Will try to check it assap.
 >> 
 >> Thanks for the report.
 >> 
 >> Vitalie
 >> 
 >> 
 >> >>> Sam Steingold on Wed, 18 Sep 2013 09:26:20 -0400 wrote:
 >> > no, just pulled and merged.
 >> > I don't think I have any local changes.
 >> > I see the exact same incorrect code on
 >> 
 >> > commit 8ce72455743aebb50340135df69e2324c243e23d
 >> > Merge: 48cd5bd 3a49687
 >> > Author: Vitalie Spinu <spinuvit at gmail.com>
 >> > Date:   Sun Sep 15 23:26:09 2013 -0700
 >> 
 >> >     Merge branch 'trunk'
 >> 
 >> > On Tue, Sep 17, 2013 at 11:38 PM, Vitalie Spinu <spinuvit at gmail.com> wrote:
 >> >>
 >> >> git show  e9a3e4c08
 >> >> fatal: ambiguous argument 'e9a3e4c08': unknown revision or path not in the working tree.
 >> >> Use '--' to separate paths from revisions
 >> >>
 >> >> Is this some 2-3 months old ESS merged with your local changes?
 >> >>
 >> >> Please make sure that it is the most recent version of our master branch
 >> >> that you are reporting from.
 >> >>
 >> >> Vitalie
 >> >>
 >> >> >>> Sam Steingold on Tue, 17 Sep 2013 16:50:42 -0400 wrote:
 >> >>
 >> >> >> * Sam Steingold <fqf at tah.bet> [2013-09-17 16:44:32 -0400]:
 >> >> >>
 >> >> >> while typing in a comment line in an R buffer, I get this error:
 >> >> >> ("tim" is the part of the word "time" which I managed to finish before
 >> >> >> being hit with the error)
 >> >> >>
 >> >> >> Debugger entered--Lisp error: (wrong-type-argument sequencep tim)
 >> >> >> replace-regexp-in-string("\\\\" "\\\\" tim nil t)
 >> >> >> ess-quote-special-chars(tim)
 >> >> >> ess-function-arguments(tim #<process R>)
 >> >> >> ess-R-eldoc-function()
 >> >>
 >> >> > the cause is that `symbol-at-point' returns a symbol, not a string, and
 >> >> > that symbol is passed to ess-quote-special-chars which expects a
 >> >> > string.
 >> >>
 >> >> > The solution is to use (thing-at-point 'symbol) instead of
 >> >> > (symbol-at-point).
 >> >>
 >> >> > Do you want a patch (or git pull request)?