[ESS-bugs] Re^2: Re: Patch: correctly indent #! and recognize Rscript

[Sebastian P. Luque]

On Mon, 12 Apr 2010 18:26:22 +0200,
Martin Maechler <maechler at stat.math.ethz.ch> wrote:

>>>>>> "JA" == Jeffrey Arnold <jarnold7 at mail.rochester.edu> on Mon, 12
>>>>>> Apr 2010 12:08:25 -0400 writes:

JA> The problem was that rev 4288 didn't update ess-indent-line to
JA> handle the shebang. Since TAB is bound to ess-indent-command and
JA> ess-indent-command calls ess-indent-line and not S-indent-line or
JA> the current indent-line-function, nothing was happening.  The patch
JA> I attached fixes ess-indent-line. I hope this patch get everything
JA> working.

> so do I.

> I'm sorry I forgot to mention "first round" that your patch partially
> failed (or it failed for me) for ess-mode.el and hence was missing in
> the commit [ Because of "intermediately being distracted" (working at
> home, over the weekend), I forgot to first ask Jeffrey (about a new
> patch) before asking everyone else for feedback.  (the lisp/ChangeLog
> already mentioned ess-mode.el ...) ] Exuse that..

Thanks for clarifying Martin!


> I have now committed rev 4289 .. which - as Jeff said - should fix the
> remaining extraneous indenting.

> I'll be glad for confirmation, Seb.

AFAICS the new version works as expected, although I haven't done
extensive checking/testing.

Thanks to Jeffrey for the patch!


-- 
Seb