[ESS-bugs] Re^2: Re: Patch: correctly indent #! and recognize Rscript

[Sebastian P. Luque]

On Sat, 10 Apr 2010 20:55:44 +0200,
Martin Maechler <maechler at stat.math.ethz.ch> wrote:

>>>>>> "MM" == Martin Maechler <maechler at stat.math.ethz.ch> on Fri, 9
>>>>>> Apr 2010 15:31:29 +0200 writes:

MM> This was accidentally sent to ESS-bugs-owner at ...  the mailbox of the
MM> ESS-bugs mailing list manager; not something I read daily.

MM> The patch looks fairly comprehensive, but as I'm not using
MM> "#!... Rscript or "littler" scripts, I'd be happy for someone else
MM> to test this.

> I would still be.  But only now I've tried to *apply* the patch to the
> current sources "started at it" a bit, use 'make' and for possible
> byte compiler warnings, and then committed it.  I'm not 100% sure if
> the patch applied correctly.

> Jeffrey, can you try using the ESS development version from the
> https://svn.r-project.org/ESS/trunk/ or any other "littler" or
> "Rscript" script writers among us?

I just tried this, given that I regularly write littler scripts.  After
upgrading my SVN copy, running make, and then after 'emacs -Q':

(load "~/.emacs.d/site-lisp/ess/lisp/ess-site")

opening a *.r script having the shebang line:

#! /usr/bin/env r

and hitting TAB (`ess-indent-command') on that line indented it as a '#'
comment, i.e. it went from starting in the first column to starting in
the 40th column.  So it seems as if the patch didn't work/apply
correctly.


-- 
Seb