[ESS-bugs] ess-eval-deactivate-mark doesn't work (patch included)

[David Reitter]

Martin,

> I cannot confirm the bug that your patch is supposedly fixing.
> Could it be that the problem is  Mac or even aquamacs specific?

Turns out it's not Aquamacs specific, and that sort of thing wouldn't  
commonly be Mac-specific, either:

Emacs -Q

(load "~/sv.aquamacs-emacs.git/aquamacs/src/site-lisp/edit-modes/ess- 
mode/lisp/ess-site.el")

M-x R
C-x b *scratch*
M-x R-mode

print("hello")

(mark line above as region with mouse or keyboard, then C-c C-r)

ess-eval-deactivate-mark ==> nil
transient-mark-mode ==> t

This even reproduces with Emacs -Q -nw, so I really can't see how it  
would be Mac-specific.


> What's the exact versions of Emacs and ESS you are using?

emacs-version => 23.0.92.19  (this is a very recent Emacs build from  
the GNU Emacs trunk)
ess-version => 5.3.10  (as included in Aquamacs - looking at my Git  
log, it's vanilla)

The newer release 5.3.11 does not seem to have changed anything in  
this department.

I just tested with the latest Emacs 22 branch build of Aquamacs.  It  
shows the same behavior: the region is deactivated after C-c C-r.
>
> For me, switching  ess-eval-deactivate-mark  from default t to
> nil, does  indeed change the "transient-mark" behavior; i.e.,
> the mark remains transiently visible after C-c C-r == ess-eval-region,
>

It doesn't do that for me, and the default of ess-eval-deactivate-mark  
is nil.  This is set so in ess-cust.el:
https://svn.r-project.org/ESS/trunk/lisp/ess-cust.el

Hope that's enough info!

- David