[ESS-bugs] ess-mode 5.3.8; after-change-functions; RET at end of file

[Sparapani, Rodney]

Hi Gang:

I don't have my natural access (I'm slumming with Windows for the
holiday break :o( ).  But, I managed some testing of the code with 
difficulty.  And, I don't think I agree with the current changes.  

Here's what you have:

    (if (and (>= emacs-major-version 21)
	     (not (featurep 'xemacs)))
	(add-hook 'after-change-functions 'noweb-after-change-function nil t)
      ;; else Xemacs or very old GNU Emacs
      (make-local-hook 'after-change-functions)
      (add-hook 'after-change-functions 'noweb-after-change-function))

I think you really want something like this:

      (if (featurep 'xemacs) (make-local-hook 'after-change-functions))
      (add-hook 'after-change-functions 'noweb-after-change-function nil t)

Rodney 

-----Original Message-----
From: ess-core-bounces at stat.math.ethz.ch on behalf of Martin Maechler
Sent: Wed 11/26/2008 2:02 AM
To: Markus Triska
Cc: Martin Maechler; ess-bugs at stat.math.ethz.ch
Subject: Re: [ESS-bugs] ess-mode 5.3.8; after-change-functions;RET at end of file
 
Hi Markus,
>>>>> "MT" == Markus Triska <markus.triska at gmx.at>
>>>>>     on Tue, 25 Nov 2008 22:00:17 +0100 writes:

    MT> Hi Martin,
    MT> Martin Maechler <maechler at stat.math.ethz.ch> writes:

    >> Still we need some tests there.. before I want to release 5.3.10 ..

    MT> I tested the new version with Emacs CVS (23.0.60), and it worked - thank
    MT> you. I'm sorry to have overlooked this mistake in the snippet!

    MT> While testing the latest ESS SVN version, I found another issue: With
    MT> point at the beginning of an empty line inside a LaTeX section of an Rnw
    MT> file, I press "<". Then ESS (as expected) inserts "<<>>=", and the major
    MT> mode changes to ess-mode. When I then press C-a C-k to delete that line
    MT> again, the major mode unexpectedly remains ess-mode for that section.

Hmm, thanks for the report.
Unfortunately I (and others) have repeatedly found that the
 text <-> code   mode switching for editing Rnw files, has
sometimes been behaving "illogically" / "stubornly" / ....

I have never started trying to find out how to fix it.
If you (or anyone in ESS-core {which is listening to ESS-bugs})
have time  or know of someone else (smart in Emacs & Emacs lisp)
who'd have, we'd be very glad for helping hands...


    MT> In addition, when byte-compiling the SVN version with the latest Emacs
    MT> CVS version, I see several warnings of the form:

    MT> noweb-mode.el:1688:27:Warning: `next-line' used from Lisp code
    MT> That command is designed for interactive use only

    MT> This can have unintended and rather strange effects in the new Emacs
    MT> version: `line-move-visual' now defaults to "t", and `next-line' thus
    MT> behaves now even more differently from `forward-line' than previously.

Ok, that sounds like something that is fixable before release.

Thanks a lot, Markus!
Martin

_______________________________________________
ESS-bugs ESS-bugs at stat.math.ethz.ch
https://stat.ethz.ch/mailman/listinfo/ess-bugs

_______________________________________________
ESS-core list: https://stat.ethz.ch/mailman/listinfo/ess-core