[ESS-bugs] ess-mode 5.3.8; after-change-functions; RET at end of file

[Martin Maechler]

>>>>> "MM" == Martin Maechler <maechler at stat.math.ethz.ch>
>>>>>     on Tue, 25 Nov 2008 15:51:19 +0100 writes:

>>>>> "MT" == Markus Triska <markus.triska at gmx.at>
>>>>>     on Mon, 10 Nov 2008 21:58:30 +0100 writes:

    MT> Hi Rodney,
    MT> Rodney Sparapani <rsparapa at mcw.edu> writes:

    >>> (if (fboundp 'make-local-hook) (progn
    >>> (make-local-hook 'after-change-functions)
    >>> (add-local-hook 'after-change-functions 'noweb-after-change-function))
    >>> (add-hook 'after-change-functions 'noweb-after-change-function nil t))

    MT> Yes, this is a good way to stay backwards compatible.

    MM> Well, this is the bug that I only now detected and which
    MM> "completely" breaks Rnw-mode
    MM> such that I had to retract the freshly released ESS 5.3.9 :

    MM> make-local-hook  is defined, but
    MM> add-local-hook  does not exist  ===> error   

    MM> and the whole  Rnw-mode is  broken.

    MM> If I replace 'add-local-hook' by 'add-hook', things seem to
    MM> work, but of course it's still the wrong if branch.
    MM> The point would have been *NOT* to use make-local-hook
    MM> unless in very outdated versions of emacs.

    MM> I am fixing it now (please don't touch it for the moment)...

I have now committed my fix,...

    MM> Do we really still need to support Emacs 20.x ?
    MM> [ The one I have here does no longer work -- it is not finding
    MM> /usr/lib/X11/locale/locale.alias  and bails out ]

but really can't easily test any Xemacs (my versions of Xemacs give
  warnings (or even errors) in my unicode locale, and when I use
 'xemacs -q' and then try load ess-site I get another error.....
nor Emacs 20.
It seems Emacs 21.x does work.

    MM> What about Xemacs? How old versions are supported there?
    MM> I currently seem to have access to 21.4.17 on one platform and
    MM> 21.4.21 on another.

Still we need some tests there..
before I want to release 5.3.10 ..

Martin