[ESS-bugs] ESS 5.3.7: Bug

[Will]

Hi, there!

Thanks for your quick response! Yes, I suggest to include my corrected 
function into ESS (without the comments). I'd like to point out that 
adding <ess-sas-submit-command-options>, ".sas", and the necessary 
blanks is necessary if you want to configure SAS under Batch Mode (the 
only mode working under MS Windows) so one can submit code and call the 
data viewer from within ESS. Otherwise the necessary options for 
submitting code and viewing data will conflict.

I found the email again I posted on 2007-10-11 to the ess-bugs list 
where this issue is described in more detail. If I can get access to the 
  ESS repository I can also change the function myself.

Best, Will

Martin Maechler wrote:
>>>>>> "RoSp" == Rodney Sparapani <rsparapa at mcw.edu>
>>>>>>     on Fri, 16 May 2008 14:49:25 -0500 writes:
> 
>     RoSp> Will wrote:
>     >> 
>     >> As I have reported this bug already in the last ESS version 5.3.6, and 
>     >> now in 5.3.7, I hope it will be included in version 5.3.8.
>     >> 
>     >> Best, Will
>     >> 
>     >> ;; corrected function
>     >> 
>     >> (defun ess-sas-submit-region ()
>     >> "Write region to temporary file, and submit to SAS."
>     >> (interactive)
>     >> (ess-sas-file-path)
>     >> (write-region (region-beginning) (region-end)
>     >> (concat (ess-sas-temp-root) ".sas"))
>     >> 
>     >> (save-excursion
>     >> (ess-sas-goto-shell t)
>     >> 
>     >> (if (and (w32-shell-dos-semantics)
>     >> (string-equal ":" (substring ess-sas-file-path 1 2)))
>     >> (progn
>     >> (insert (substring ess-sas-file-path 0 2))
>     >> (comint-send-input)
>     >> ))
>     >> 
>     >> (insert "cd \"" (convert-standard-filename
>     >> (file-name-directory ess-sas-file-path)) "\"")
>     >> (comint-send-input)
>     >> 
>     >> (insert (concat ess-sas-submit-pre-command " "
>     >> ess-sas-submit-command " "
>     >> ess-sas-submit-command-options " " ;; corrected l. 1
>     >> (ess-sas-temp-root) ".sas" " " ;; corrected l. 2
>     >> ess-sas-submit-post-command)
>     >> )
>     >> (comint-send-input)
>     >> )
>     >> )
>     >> 
>     RoSp> Is there something weird going on with the repository?  According to my 
>     RoSp> checkout,
>     RoSp> ess-sas-submit-command-options is not used by the function 
>     RoSp> ess-sas-submit-region.
> 
> That's correct. It's not used currently;
> Will, are you proposing to use it? 
> 
> Will, you can always access the current (development) version
> of the ESS code at svn.r-project.org, for the current situation,
> it is 
>  https://svn.r-project.org/ESS/trunk/lisp/essa-sas.el
> 
> 
>     RoSp> Can anyone else see this bug?
> 
> I'm not sure, but I think you are the only one (inside ESS-core)
> ever using ESS for SAS.
> Of course, I would use ESS if I ever had to use SAS ..
> 
> Martin
> 
> 
>     RoSp> -- 
>     RoSp> Rodney Sparapani             Medical College of Wisconsin
>     RoSp> Sr. Biostatistician          Center for Patient Care & Outcomes Research
>     RoSp> Was Name That Tune rigged?   Milwaukee, WI, USA
> 
>     RoSp> _______________________________________________
>     RoSp> ESS-bugs ESS-bugs at stat.math.ethz.ch
>     RoSp> https://stat.ethz.ch/mailman/listinfo/ess-bugs
> 
>     RoSp> _______________________________________________
>     RoSp> ESS-core list: https://stat.ethz.ch/mailman/listinfo/ess-core