[ESS-bugs] ess-mode 5.3.4; Words of praise, suggestions

[Markus Triska]

Hi Stephen,

Stephen Eglen <S.J.Eglen at damtp.cam.ac.uk> writes:

> Thanks too for the comments about updating noweb-mode.el --- that is
> long overdue a major reworking, and is on my list of things to look
> at!

OK; there are also several wrongly nested save-excursion/restriction
pairs. From the documentation of save-restriction:

    Note: if you are using both `save-excursion' and `save-restriction',
    use `save-excursion' outermost:
        (save-excursion (save-restriction ...))

You can see that the order does makes a difference by putting this in
the *scratch* buffer and evaluating the expression with C-x C-e:

    (save-restriction   ;
      (save-excursion   ; *WRONG* NESTING ORDER!
        (goto-char (point-max))
        (narrow-to-region (1- (point)) (point))))
    ; copy this comment too

contrast it with the result of:

    (save-excursion
      (save-restriction  ; correct order
        (goto-char (point-max))
        (narrow-to-region (1- (point)) (point))))
    ; copy this comment too


All the best,
Markus Triska