That's correct, sorry that I did not make that more obvious. We just need
to change that function to check identical("-99") instead of
identical("unknown").

Thanks,
Michael


On Fri, Mar 8, 2013 at 7:38 AM, Dan Tenenbaum <dtenenba@fhcrc.org> wrote:

> On Fri, Mar 8, 2013 at 6:16 AM, Martin Morgan <mtmorgan@fhcrc.org> wrote:
> > On 03/08/2013 05:28 AM, Michael Lawrence wrote:
> >>
> >> Hi,
> >>
> >> My Linux package manager supports building packages from svn, but it
> >> exports the files into a sandbox directory prior to building. This
> causes
> >> 'svn info' to fail in the R build process. (It would probably be cleaner
> >
> >
> > This thread
> >
> >   https://stat.ethz.ch/pipermail/r-devel/2013-February/065886.html
> >
> > is in essence the same issue (Matrix tests svn revision to determine
> > exports, svn revision is not defined in the way the user is building R),
> and
> > it might be helpful to bring this up in your context on R-devel.
> >
> >
> >> for R to record the svn revision in an svn hook, but that's besides the
> >> point). Before October, the unknown revision was indicated by the
> >> "unknown"
> >> string, and biocLite would emit a warning (but not an error). Since
> >
> >
> > Can you connect the dots a bit more for me, please, I'm not understanding
> > where this warning / error is coming from?
> >
>
> I think from BiocInstaller:::.checkSvnRevision()?
>
> Dan
>
>
>
>
> > Martin
> >
> >
> >> October, the data type of the R_SVN_REVISION has changed to integer, and
> >> unknown is indicated by -99. Could this be added to the check in
> >> BiocInstaller?
> >>
> >> Thanks,
> >> Michael
> >>
> >>         [[alternative HTML version deleted]]
> >>
> >> _______________________________________________
> >> Bioconductor mailing list
> >> Bioconductor@r-project.org
> >> https://stat.ethz.ch/mailman/listinfo/bioconductor
> >> Search the archives:
> >> http://news.gmane.org/gmane.science.biology.informatics.conductor
> >>
> >
> >
> > --
> > Computational Biology / Fred Hutchinson Cancer Research Center
> > 1100 Fairview Ave. N.
> > PO Box 19024 Seattle, WA 98109
> >
> > Location: Arnold Building M1 B861
> > Phone: (206) 667-2793
> >
> >
> > _______________________________________________
> > Bioconductor mailing list
> > Bioconductor@r-project.org
> > https://stat.ethz.ch/mailman/listinfo/bioconductor
> > Search the archives:
> > http://news.gmane.org/gmane.science.biology.informatics.conductor
>

	[[alternative HTML version deleted]]

