[Bioc-devel] affy's cleancdfname

[Seth Falcon]

There seems to be some inconsistencies in when cleancdfname is called
in getCDFenv.R.

getCdfInfo() calls the following helpers:
  cdfFromEnvironment() ## no call to cleancdfname
  cdfFromData()        ## no call to cleancdfname
  cdfFromLibPath()     ## calls cleancdfname
  cdfFromBioC()        ## calls cleancdfname

I have two alternatives to propose and would like comments:

1. remove cleancdfname calls from cdfFrom* funcs and put the call in
   getCdfInfo().  This feels right in that we call the func once, but
   it changes the behavior of two of the cdfFrom* funcs where to use
   them a user would now have to call cleancdfname themselves.

2. Change behavior of cleancdfname so that repeated calls don't add
   additional "cdf" to the end.  This would make the assumption that
   no valid cdf package name ends "cdfcdf".

+ seth