[Rd] R-devel does not compile on OpenSUSE 15.4

[Gábor Csárdi]

I think this was possibly a typo (ALL_FCLAGS vs ALL_FCFLAGS), plus
those flags were never set for src/modules/lapack. Hence, this seems
like a better fix, that also adds the flags to src/extra/blas.

Best,
Gabor

diff --git a/src/extra/blas/Makefile.in b/src/extra/blas/Makefile.in
index 3661416..c9b53e2 100644
--- a/src/extra/blas/Makefile.in
+++ b/src/extra/blas/Makefile.in
@@ -17,7 +17,7 @@ include $(top_builddir)/Makeconf

 ALL_CFLAGS = $(ALL_CFLAGS_LO)
 ALL_FFLAGS = $(ALL_FFLAGS_LO)
-ALL_FCLAGS = $(ALL_FFLAGS_LO)
+ALL_FCFLAGS = $(ALL_FFLAGS_LO)

 SOURCES = blas00.c blas.f cmplxblas.f blas2.f90 cmplxblas2.f90

diff --git a/src/modules/lapack/Makefile.in b/src/modules/lapack/Makefile.in
index 8e593ea..e35c956 100644
--- a/src/modules/lapack/Makefile.in
+++ b/src/modules/lapack/Makefile.in
@@ -15,6 +15,10 @@ include $(top_builddir)/Makeconf
 .f90.o:
        $(FC) $(ALL_FCFLAGS) -c @FCFLAGS_f90@ $< -o $@

+ALL_CFLAGS = $(ALL_CFLAGS_LO)
+ALL_FFLAGS = $(ALL_FFLAGS_LO)
+ALL_FCFLAGS = $(ALL_FFLAGS_LO)
+
 SOURCES_C = Lapack.c @USE_VECLIB_G95FIX_TRUE@ vecLibg95c.c
 SOURCES_F = @USE_VECLIB_G95FIX_TRUE@ vecLibg95f.f

On Wed, Feb 8, 2023 at 2:03 PM Gábor Csárdi <csardi.gabor using gmail.com> wrote:
>
> More precisely the built-in Lapack module. AFAICT this is because the
> f90 files are not compiled with -fpic. My output:
>
> make[4]: Entering directory '/tmp/R-devel/src/modules/lapack'
> gfortran -fpic  -g -O2 -msse2 -mfpmath=sse  -c dlamch.f -o dlamch.o
> gfortran  -fpic  -g -O2  -c dlapack.f -o dlapack.o
> gfortran  -fpic  -g -O2  -c cmplx.f -o cmplx.o
> gfortran  -c  la_constants.f90 -o la_constants.o
> gfortran  -c  dlartg.f90 -o dlartg.o
> gfortran  -c  la_xisnan.f90 -o la_xisnan.o
> gfortran  -c  dlassq.f90 -o dlassq.o
> gfortran  -c  zlartg.f90 -o zlartg.o
> gfortran  -c  zlassq.f90 -o zlassq.o
> gcc -shared -fopenmp -L/usr/local/lib64 -o libRlapack.so dlamch.o
> dlapack.o cmplx.o dlartg.o dlassq.o la_constants.o la_xisnan.o
> zlartg.o zlassq.o   -L"../../../lib" -lRblas -lgfortran -lm -lquadmath
> /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld:
> zlassq.o: warning: relocation against `__la_xisnan_MOD_disnan' in
> read-only section `.text'
> /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld:
> dlassq.o: relocation R_X86_64_PC32 against symbol
> `__la_xisnan_MOD_disnan' can not be used when making a shared object;
> recompile with -fPIC
> /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld:
> final link failed: bad value
> collect2: error: ld returned 1 exit status
>
> If I update src/modules/lapack/Makefile.in to add $(FPICFLAGS) to the
> .f90 compilation, then all is good. I assume you would also want to
> add -g and -O2 here, so probably some other variable is better than
> $(FPICFLAGS).
>
> FYI,
> Gabor